Skip to content

Conversation

@andrey-legayev
Copy link
Contributor

Description (*)

There were no way to disable JS bundles even if you don't use them on frontend.
Disabling generation of JS bundles improves speed of Static Content Deploy and makes build package smaller in MB.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Run static content deploy with option --no-js-bundle
  2. JS bundles should not be generated

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

There were no way to disable JS bundles even if you don't use them.
Disabling generation of JS bundles improves speed of Static Content
Deploy and makes build package smaller.
@m2-assistant
Copy link

m2-assistant bot commented Oct 7, 2019

Hi @andrey-legayev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ihor-sviziev ihor-sviziev self-assigned this Oct 8, 2019
@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Oct 8, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6041 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Golf engcom-Golf self-assigned this Oct 10, 2019
@VladimirZaets VladimirZaets added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Oct 16, 2019
@magento-engcom-team magento-engcom-team merged commit 7e8defe into magento:2.3-develop Oct 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 18, 2019

Hi @andrey-legayev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 18, 2019
@ihor-sviziev ihor-sviziev deleted the 2.3-disable-js-bundles branch September 4, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants