Skip to content

Fixed required class is missing in load template #24981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2019
Merged

Fixed required class is missing in load template #24981

merged 1 commit into from
Oct 18, 2019

Conversation

@gaurav-473
Copy link
Contributor

@gaurav-473 gaurav-473 commented Oct 11, 2019 •
edited
Loading

Description (*)

Required class is missing in load template

Manual testing scenarios (*)

  1. Marketing -> Email Template -> Load Template
  2. Template is required field but required class is missing.

Screenshot_2019-10-11_15-20-31

@gaurav-473 gaurav-473 requested a review from melnikovi as a code owner October 11, 2019 09:50
@m2-assistant
Copy link

m2-assistant bot commented Oct 11, 2019

Hi @gauravagarwal1001. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@gaurav-473
Copy link
Contributor Author

gaurav-473 commented Oct 11, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 11, 2019

Hi @gauravagarwal1001. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 11, 2019

Hi @gauravagarwal1001, here is your new Magento instance.
Admin access: https://pr-24981.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@gaurav-473
Copy link
Contributor Author

gaurav-473 commented Oct 11, 2019

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 11, 2019

Hi @gauravagarwal1001. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 11, 2019

Hi @gauravagarwal1001, here is your Magento instance.
Admin access: https://i-24981-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@gaurav-473 gaurav-473 closed this Oct 11, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 11, 2019

Hi @gauravagarwal1001, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gaurav-473 gaurav-473 reopened this Oct 11, 2019
@dmytro-ch dmytro-ch self-assigned this Oct 13, 2019
@dmytro-ch dmytro-ch self-requested a review October 13, 2019 14:28
@dmytro-ch
Copy link
Contributor

dmytro-ch commented Oct 13, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 13, 2019

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 13, 2019

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-24981.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@dmytro-ch dmytro-ch added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 13, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 13, 2019

Hi @dmytro-ch, thank you for the review.
ENGCOM-6068 has been created to process this Pull Request

@gaurav-473 gaurav-473 closed this Oct 14, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 14, 2019

Hi @gauravagarwal1001, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@gaurav-473 gaurav-473 reopened this Oct 14, 2019
@ghost ghost unassigned dmytro-ch Oct 14, 2019
@gaurav-473 gaurav-473 requested a review from dmytro-ch October 15, 2019 10:50
@dmytro-ch dmytro-ch self-assigned this Oct 16, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 16, 2019

Hi @dmytro-ch, thank you for the review.
ENGCOM-6103 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Oct 16, 2019
@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Oct 16, 2019

✔️ QA Passed

Before:
before

After:
after

@engcom-Golf engcom-Golf self-assigned this Oct 16, 2019
magento-engcom-team pushed a commit that referenced this pull request Oct 18, 2019
@VladimirZaets
ENGCOM-6103: Fixed required class is missing in load template #24981
2958ef2
@magento-engcom-team magento-engcom-team merged commit fa9745c into magento:2.3-develop Oct 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 18, 2019

Hi @gauravagarwal1001, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 18, 2019
@engcom-Foxtrot
Copy link
Contributor

engcom-Foxtrot commented Dec 16, 2019

Covering

p-bystritsky added a commit to p-bystritsky/magento2 that referenced this pull request Dec 16, 2019
@p-bystritsky
Test for magento#24981.
9723876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@melnikovi melnikovi Awaiting requested review from melnikovi

Assignees

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Golf engcom-Golf

Labels

Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Community Insider: Cedcommerce community-insider-contribution Component: Email Progress: accept Release Line: 2.3 Squashtoberfest 2019

Projects

None yet

Milestone

Release: 2.3.4

Development

Successfully merging this pull request may close these issues.

6 participants

@gaurav-473 @magento-engcom-team @dmytro-ch @engcom-Alfa @engcom-Foxtrot @engcom-Golf