-
Notifications
You must be signed in to change notification settings - Fork 9.4k
DI Compile - Sort DI metadata output to make diff between builds easier #24898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DI Compile - Sort DI metadata output to make diff between builds easier #24898
Conversation
|
Hi @andrey-legayev. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
|
Hi @ihor-sviziev, thank you for the review. |
|
✔️ QA Passed |
|
Hi @andrey-legayev, thank you for your contribution! |
|
Covered by |
Description (*)
We've faced an issue on BitBucket Pipelines: every build had own unique order of keys inside DI Metadata files.
We couldn't see the real diff between builds because of it.
Simple alphabetical sorting of metadata keys resolves this issue and makes builds repeatable.
Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
Questions or comments
N/A
Contribution checklist (*)