Releases: lightningdevkit/rust-lightning
v0.0.121
0.0.121 - Jan 22, 2024 - "Unwraps are Bad"
Bug Fixes
- Fix a deadlock when calling
batch_funding_transaction_generatedwith
invalid input (#2841).
Security
0.0.121 fixes a denial-of-service vulnerability which is reachable from
untrusted input from peers in rare cases if we have a public channel or in
common cases if P2PGossipSync is used.
- A peer that failed to complete its handshake would cause a reachable
unwrapin LDK since 0.0.119 when LDK attempts to broadcast gossip to all
peers (#2842).
In total, this release features 4 files changed, 52 insertions, 10
deletions in 4 commits from 2 authors, in alphabetical order:
- Jeffrey Czyz
- Matt Corallo
v0.0.120
v0.0.120 - Jan 17, 2024 - "Unblinded Fuzzers"
API Updates
- The
PeerManagerbound onUtxoLookupwas removed entirely. This enables
use ofUtxoLookupin cases broken in 0.0.119 by #2773 (#2822). - LDK now exposes and fully implements the route blinding feature (#2812).
- The
lightning-transaction-synccrate no longer relies on system time
without thetimefeature (#2799, #2817). lightning::onion_message's module layout has changed (#2821).Event::ChannelClosednow includes thechannel_funding_txo(#2800).CandidateRouteHopvariants were destructured into individual structs,
hiding some fields which were not generally consumable (#2802).
Bug Fixes
- Fixed a rare issue where
lightning-net-tokiomay not fully flush its send
buffer, leading to connection hangs (#2832). - Fixed a panic which may occur when connecting to a peer if we opened a second
channel with that peer while they were disconnected (#2808). - Retries for a payment which previously failed in a blinded path will now
always use an alternative blinded path (#2818). Feature'sEqandHashimplementation now ignore dummy bytes (#2808).- Some missing
DiscardFundingorChannelClosedevents are now generated in
rare funding-related failures (#2809). - Fixed a privacy issue in blinded path generation where the real
cltv_expiry_deltawould be exposed to senders (#2831).
Security
0.0.120 fixes a denial-of-service vulnerability which is reachable from
untrusted input from peers if the UserConfig::manually_accept_inbound_channels
option is enabled.
- A peer that sent an
open_channelmessage with thechannel_typefield
unfilled would trigger a reachableunwrapsince LDK 0.0.117 (#2808). - In protocols where a funding output is shared with our counterparty before
it is given to LDK, a malicious peer could have caused a reachable panic
by reusing the same funding info in (#2809).
In total, this release features 67 files changed, 3016 insertions, 2473
deletions in 79 commits from 9 authors, in alphabetical order:
- Elias Rohrer
- Jeffrey Czyz
- José A.P
- Matt Corallo
- Tibo-lg
- Valentine Wallace
- benthecarman
- optout
- shuoer86
v0.0.119
v0.0.119 - Dec 15, 2023 - "Spring Cleaning for Christmas"
API Updates
- The LDK crate ecosystem MSRV has been increased to 1.63 (#2681).
- The
bitcoindependency has been updated to version 0.30 (#2740). lightning-invoice::payment::*have been replaced with parameter generation
viapayment_parameters_from[_zero_amount]_invoice(#2727).{CoinSelection,Wallet}Source::sign_txare nowsign_psbt, providing more
information, incl spent outputs, about the transaction being signed (#2775).- Logger
Records now includechannel_idandpeer_idfields. These are
opportunistically filled in when a log record is specific to a given channel
and/or peer, and may occasionally be spuriously empty (#2314). - When handling send or reply onion messages (e.g. for BOLT12 payments), a new
Event::ConnectionNeededmay be raised, indicating a direct connection
should be made to a payee or an introduction point. This event is expected to
be removed once onion message forwarding is widespread in the network (#2723) - Scoring data decay now happens via
ScoreUpDate::time_passed, called from
lightning-background-processor.process_events_asyncnow takes a new
time-fetch function, andScoreUpDatemethods now take the current time as a
Durationargument. This avoids fetching time during pathfinding (#2656). - Receiving payments to multi-hop blinded paths is now supported (#2688).
MessageRouterandRouternow feature methods to generate blinded paths to
the local node for incoming messages and payments.Routernow extends
MessageRouter, and both are used inChannelManagerwhen processing or
creating BOLT12 structures to generate multi-hop blinded paths (#1781).lightning-transaction-syncnow supports Electrum-based sync (#2685).Confirm::get_relevant_txidsnow returns the height at which a transaction
was confirmed. This can be used to assist in reorg detection (#2685).ConfirmationTarget::MaxAllowedNonAnchorChannelRemoteFeehas been removed.
Non-anchor channel feerates are bounded indirectly through
ChannelConfig::max_dust_htlc_exposure(#2696).lightning-invoiceDescriptions now rely onUntrustedStringfor
sanitization (#2730).ScoreLookUp::channel_penalty_msatnow usesCandidateRouteHop(#2551).- The
EcdsaChannelSignertrait was moved tolightning::sign::ecdsa(#2512). SignerProvider::get_destination_scriptnow takeschannel_keys_id(#2744)SpendableOutputDescriptor::StaticOutputnow haschannel_keys_id(#2749).EcdsaChannelSigner::sign_counterparty_commitmentnow takes HTLC preimages
for both inbound and outbound HTLCs (#2753).ClaimedHTLCnow includes acounterparty_skimmed_fee_msatfield (#2715).peel_payment_onionwas added to decode an encrypted onion for a payment
without receiving an HTLC. This allows for stateless verification of if a
theoretical payment would be accepted prior to receipt (#2700).create_payment_onionwas added to construct an encrypted onion for a
payment path without sending an HTLC immediately (#2677).- Various keys used in channels are now wrapped to provide type-safety for
specific usages of the keys (#2675). TaggedHashnow includes the rawtagandmerkle_root(#2687).Offer::is_expired_no_stdwas added (#2689).PaymentPurpose::preimage()was added (#2768).temporary_channel_idcan now be specified increate_channel(#2699).- Wire definitions for splicing messages were added (#2544).
- Various
lightning-invoicestructs now implDisplay, now have pub fields,
or implFrom(#2730). - The
Hashtrait is now implemented for more structs, incl P2P msgs (#2716).
Performance Improvements
- Memory allocations (though not memory usage) have been substantially reduced,
meaning less overhead and hopefully less memory fragmentation (#2708, #2779).
Bug Fixes
- Since 0.0.117, calling
close_channel*on a channel which has not yet been
funded would previously result in an infinite loop and hang (#2760). - Since 0.0.116, sending payments requiring data in the onion for the recipient
which was too large for the onion may have caused corruption which resulted
in payment failure (#2752). - Cooperative channel closure on channels with remaining output HTLCs may have
spuriously force-closed (#2529). - In LDK versions 0.0.116 through 0.0.118, in rare cases where skimmed fees are
present on shutdown theChannelManagermay fail to deserialize (#2735). ChannelConfig::max_dust_exposurevalues which, converted to absolute fees,
exceeded 2^63 - 1 would result in an overflow and could lead to spurious
payment failures or channel closures (#2722).- In cases where LDK is operating with provably-stale state, it panics to
avoid funds loss. This may not have happened in cases where LDK was behind
only exactly one state, leading instead to a revoked broadcast and funds
loss (#2721). - Fixed a bug where decoding
Txids from Bitcoin Core JSON-RPC responses using
lightning-block-syncwould not properly byte-swap the hash. Note that LDK
does not use this API internally (#2796).
Backwards Compatibility
ChannelManagers written with LDK 0.0.119 are no longer readable by versions
of LDK prior to 0.0.113. Users wishing to downgrade to LDK 0.0.112 or before
can read an 0.0.119-serializedChannelManagerwith a version of LDK from
0.0.113 to 0.0.118, re-serialize it, and then downgrade (#2708).- Nodes that upgrade to 0.0.119 and subsequently downgrade after receiving a
payment to a blinded path may leak recipient information if one or more of
those HTLCs later fails (#2688). - Similarly, forwarding a blinded HTLC and subsequently downgrading to an LDK
version prior to 0.0.119 may result in leaking the path information to the
payment sender (#2540).
In total, this release features 148 files changed, 13780 insertions, 6279
deletions in 280 commits from 22 authors, in alphabetical order:
- Arik Sosman
- Chris Waterson
- Elias Rohrer
- Evan Feenstra
- Gursharan Singh
- Jeffrey Czyz
- John Cantrell
- Lalitmohansharma1
- Matt Corallo
- Matthew Rheaume
- Orbital
- Rachel Malonson
- Valentine Wallace
- Willem Van Lint
- Wilmer Paulino
- alexanderwiederin
- benthecarman
- henghonglee
- jbesraa
- olegkubrakov
- optout
- shaavan
v0.0.118
0.0.118 - Oct 23, 2023 - "Just the Twelve Sinks"
API Updates
- BOLT12 sending and receiving is now supported as an alpha feature. You may
run into unexpected issues and will need to have a direct connection with
the offer's blinded path introduction points as messages are not yet routed.
We are seeking feedback from early testers (#2578, #2039). ConfirmationTargethas been rewritten to provide information about the
specific use LDK needs the feerate estimate for, rather than the generic
low-, medium-, and high-priority estimates. This allows LDK users to more
accurately target their feerate estimates (#2660). For those wishing to
retain their existing behavior, see the table below for conversion.ChainHashis now used in place ofBlockHashwhere it represents the
genesis block (#2662).lightning-invoicepayment utilities now take aDerefto
AChannelManager(#2652).peel_onionis provided to statelessly decode anOnionMessage(#2599).ToSocketAddrs+Displayare now impl'd forSocketAddress(#2636, #2670)Displayis now implemented forOutPoint(#2649).Features::from_be_bytesis now provided (#2640).
For those moving to the new ConfirmationTarget, the new variants in terms of
the old mempool/low/medium/high priorities are as follows:
OnChainSweep=HighPriorityMaxAllowedNonAnchorChannelRemoteFee=max(25 * 250, HighPriority * 10)MinAllowedAnchorChannelRemoteFee=MempoolMinimumMinAllowedNonAnchorChannelRemoteFee=Background - 250AnchorChannelFee=BackgroundNonAnchorChannelFee=NormalChannelCloseMinimum=Background
Bug Fixes
- Calling
ChannelManager::close_channel[_with_feerate_and_script]on a
channel which did not exist would immediately hang holding several key
ChannelManager-internal locks (#2657). - Channel information updates received from a failing HTLC are no longer
applied to ourNetworkGraph. This prevents a node which we attempted to
route a payment through from being able to learn the sender of the payment.
In some rare cases, this may result in marginally reduced payment success
rates (#2666). - Anchor outputs are now properly considered when calculating the amount
available to send in HTLCs. This can prevent force-closes in anchor channels
when sending payments which overflow the available balance (#2674). - A peer that sends an
update_fulfill_htlcmessage for a forwarded HTLC,
then reconnects prior to sending acommitment_signed(thus retransmitting
theirupdate_fulfill_htlc) may result in the channel stalling and being
unable to make progress (#2661). - In exceedingly rare circumstances, messages intended to be sent to a peer
prior to reconnection can be sent after reconnection. This could result in
undefined channel state and force-closes (#2663).
Backwards Compatibility
- Creating a blinded path to receive a payment then downgrading to LDK prior to
0.0.117 may result in failure to receive the payment (#2413). - Calling
ChannelManager::pay_for_offeror
ChannelManager::create_refund_buildermay prevent downgrading to LDK prior
to 0.0.118 until the payment times out and has been removed (#2039).
Node Compatibility
- LDK now sends a bogus
channel_reestablishmessage to peers when they ask to
resume an unknown channel. This should cause LND nodes to force-close and
broadcast the latest channel state to the chain. In order to trigger this
when we wish to force-close a channel, LDK now disconnects immediately after
sending a channel-closingerrormessage. This should result in cooperative
peers also working to confirm the latest commitment transaction when we wish
to force-close (#2658).
Security
0.0.118 expands mitigations against transaction cycling attacks to non-anchor
channels, though note that no mitigations which exist today are considered robust
to prevent the class of attacks.
- In order to mitigate against transaction cycling attacks, non-anchor HTLC
transactions are now properly re-signed before broadcasting (#2667).
In total, this release features 61 files changed, 3470 insertions, 1503
deletions in 85 commits from 12 authors, in alphabetical order:
- Antonio Yang
- Elias Rohrer
- Evan Feenstra
- Fedeparma74
- Gursharan Singh
- Jeffrey Czyz
- Matt Corallo
- Sergi Delgado Segura
- Vladimir Fomene
- Wilmer Paulino
- benthecarman
- slanesuke
v0.0.117
0.0.117 - Oct 3, 2023 - "Everything but the Twelve Sinks"
API Updates
ProbabilisticScorer's internal models have been substantially improved,
including better decaying (#1789), a more granular historical channel
liquidity tracker (#2176) and a now-default option to make our estimate for a
channel's current liquidity nonlinear in the channel's capacity (#2547). In
total, these changes should result in improved payment success rates at the
cost of slightly worse routefinding performance.- Support for custom TLVs for recipients of HTLCs has been added (#2308).
- Support for generating transactions for third-party watchtowers has been
added toChannelMonitor/Updates (#2337). KVStorePersisterhas been replaced with a more generic and featureful
KVStoreinterface (#2472).- A new
MonitorUpdatingPersisteris provided which wraps aKVStoreand
implementsPersistby writing differential updates rather than full
ChannelMonitors (#2359). - Batch funding of outbound channels is now supported using the new
ChannelManager::batch_funding_transaction_generatedmethod (#2486). ChannelManager::send_preflight_probeshas been added to probe a payment's
potential paths while a user is providing approval for a payment (#2534).- Fully asynchronous
ChannelMonitorupdating is available as an alpha
preview. There remain a few known but incredibly rare race conditions which
may lead to loss of funds (#2112, #2169, #2562). ChannelMonitorUpdateStatus::PermanentFailurehas been removed in favor of a
newChannelMonitorUpdateStatus::UnrecoverableError. The new variant panics
on use, rather than force-closing a channel in an unsafe manner, which the
previous variant did (#2562). Rather than panicking with the new variant,
users may wish to use the new asynchronousChannelMonitorupdating using
ChannelMonitorUpdateStatus::InProgress.RouteParameters::max_total_routing_fee_msatwas added to limit the fees
paid when routing, defaulting to 1% + 50sats when using the new
from_payment_params_and_valueconstructor (#2417, #2603, #2604).- Implementations of
UtxoSourceare now provided inlightning-block-sync.
Those running with a full node should use this to validate gossip (#2248). LockableScorenow supports read locking for parallel routefinding (#2197).ChannelMonitor::get_spendable_outputswas added to allow for re-generation
ofSpendableOutputDescriptors for a channel after they were provided via
Event::SpendableOutputs(#2609, #2624).[u8; 32]has been replaced with aChannelIdnewtype for chan ids (#2485).NetAddresswas renamedSocketAddress(#2549) andFromStrimpl'd (#2134)- For
no-stdusers,parse_onion_addresswas added which creates a
NetAddressfrom a "...onion" string and port (#2134, #2633). - HTLC information is now provided in
Event::PaymentClaimed::htlcs(#2478). - The success probability used in historical penalties when scoring is now
available viahistorical_estimated_payment_success_probability(#2466). RecentPaymentDetails::*::payment_idhas been added (#2567).Routenow contains aRouteParametersrather than aPaymentParameters,
tracking the original arguments passed to routefinding (#2555).Balance::*::claimable_amount_satoshiswas renamedamount_satoshis(#2460)*Features::set_*_feature_bithave been added for non-custom flags (#2522).channel_idwas added toSpendableOutputsevents (#2511).counterparty_node_idandchannel_capacity_satswere added to
ChannelClosedevents (#2387).ChannelMonitornow implementsCloneforCloneable signers (#2448).create_onion_messagewas added to build an onion message (#2583, #2595).HTLCDescriptornow implementsWriteable/Readable(#2571).SpendableOutputDescriptornow implementsHash(#2602).MonitorUpdateIdnow implementsDebug(#2594).Payment{Hash,Id,Preimage}now implementDisplay(#2492).NodeSigner::sign_bolt12_invoice{,request}were added for future use (#2432)
Backwards Compatibility
- Users migrating to the new
KVStorecan use a concatentation of
[{primary_namespace}/[{secondary_namespace}/]]{key}to build a key
compatible with the previousKVStorePersisterinterface (#2472). - Downgrading after receipt of a payment with custom HTLC TLVs may result in
unintentionally accepting payments with TLVs you do not understand (#2308). Routeobjects (including pending payments) written by LDK versions prior
to 0.0.117 won't be retryable after being deserialized by LDK 0.0.117 or
above (#2555).- Users of the
MonitorUpdatingPersistercan upgrade seamlessly from the
defaultKVStorePersistimplementation, however the stored
ChannelMonitors are deliberately unreadable by the defaultPersist. This
ensures the correct downgrade procedure is followed, which is: (#2359)- First, make a backup copy of all channel state,
- then ensure all
ChannelMonitorUpdates stored are fully applied to the
relevantChannelMonitor, - finally, write each full
ChannelMonitorusing your newPersistimpl.
Bug Fixes
- Anchor channels which were closed by a counterparty broadcasting its
commitment transaction (i.e. force-closing) would previously not generate a
SpendableOutputsevent for ourto_remote(i.e. non-HTLC-encumbered)
balance. Those with such balances available should fetch the missing
SpendableOutputDescriptors using the new
ChannelMonitor::get_spendable_outputsmethod (#2605). - Anchor channels may result in spurious or missing
Balanceentries for HTLC
balances (#2610). ChannelManager::send_spontaneous_payment_with_retryspuriously did not
provide the recipient with enough information to claim the payment, leading
to all spontaneous payments failing (#2475).
send_spontaneous_payment_with_routewas unaffected.- The
keysendfeature on node announcements was spuriously un-set in 0.0.112
and has been re-enabled (#2465). - Fixed several races which could lead to deadlock when force-closing a channel
(#2597). These races have not been seen in production. - The
ChannelManageris persisted substantially less when it has not changed,
leading to substantially less I/O traffic for it (#2521, #2617). - Passing new block data to
ChainMonitorno longer results in all other
monitor operations being blocked until it completes (#2528). - When retrying payments, any excess amount sent to the recipient in order to
meet anhtlc_minimumconstraint on the path is now no longer included in
the amount we send in the retry (#2575). - Several edge cases in route-finding around HTLC minimums were fixed which
could have caused invalid routes or panics when built with debug assertions
(#2570, #2575). - Several edge cases in route-finding around HTLC minimums and route hints
were fixed which would spuriously result in no route found (#2575, #2604). - The
user_channel_idpassed toSignerProvider::generate_channel_keys_id
for inbound channels is now correctly using the one passed to
ChannelManager::accept_inbound_channelrather than a default value (#2428). - Users of
impl_writeable_tlv_based!no longer have use requirements (#2506). - No longer force-close channels when counterparties send a
channel_update
with a bogushtlc_minimum_msat, which LND users can manually build (#2611).
Node Compatibility
- LDK now ignores
errormessages generated by LND in response to a
shutdownmessage, avoiding force-closes due to LND bug 6039. This may
lead to non-trivial bandwidth usage with LND peers exhibiting this bug
during the cooperative shutdown process (#2507).
Security
0.0.117 fixes several loss-of-funds vulnerabilities in anchor output channels,
support for which was added in 0.0.116, in reorg handling, and when accepting
channel(s) from counterparties which are miners.
- When a counterparty broadcasts their latest commitment transaction for a
channel with anchor outputs, we'd previously fail to build claiming
transactions against any HTLC outputs in that transaction. This could lead
to loss of funds if the counterparty is able to eventually claim the HTLC
after a timeout (#2606). - Anchor channels HTLC claims on-chain previously spent the entire value of any
HTLCs as fee, which has now been fixed (#2587). - If a channel is closed via an on-chain commitment transaction confirmation
with a pending outbound HTLC in the commitment transaction, followed by a
reorg which replaces the confirmed commitment transaction with a different
(but non-revoked) commitment transaction, all before we learn the payment
preimage for this HTLC, we may previously have not generated a proper
claiming transaction for the HTLC's value (#2623). - 0.0.117 now correctly handles channels for which our counterparty funded the
channel with a coinbase transaction. As such transactions are not spendable
until they've reached 100 confirmations, this could have resulted in
accepting HTLC(s) which are not enforcible on-chain (#1924).
In total, this release features 121 files changed, 20477 insertions, 8184
deletions in 381 commits from 27 authors, in alphabetical order:
- Alec Chen
- Allan Douglas R. de Oliveira
- Antonio Yang
- Arik Sosman
- Chris Waterson
- David Caseria
- DhananjayPurohit
- Dom Zippilli
- Duncan Dean
- Elias Rohrer
- Erik De Smedt
- Evan Feenstra
- Gabor Szabo
- Gursharan Singh
- Jeffrey Czyz
- Joseph Goulden
- Lalitmohansharma1
- Matt Corallo
- Rachel Malonson
- Sergi Delgado Segura
- Valentine Wallace
- Vladimir Fomene
- Willem Van Lint
...
v0.0.116
0.0.116 - Jul 21, 2023 - "Anchoring the Roadmap"
API Updates
- Support for zero-HTLC-fee anchor output channels has been added and is now
considered beta (#2367). Users who set
ChannelHandshakeConfig::negotiate_anchors_zero_fee_htlc_txshould be
prepared to handle the newEvent::BumpTransaction, e.g. via the
BumpTransactionEventHandler(#2089). Note that in order to do so you must
ensure you always have a reserve of available unspent on-chain funds to use
for CPFP. LDK currently makes no attempt to ensure this for you. - Users who set
ChannelHandshakeConfig::negotiate_anchors_zero_fee_htlc_tx
and wish to accept inbound anchor-based channels must do so manually by
settingUserConfig::manually_accept_inbound_channels(#2368). - Support forwarding and accepting HTLCs with a reduced amount has been added,
to support LSPs skimming a fee on the penultimate hop (#2319). - BOLT11 and BOLT12 Invoice and related types have been renamed to include a
BOLTNN prefix, ensuring uniqueness inlightning{,-invoice}crates (#2416). Scorers now have an associated type which represents a parameter passed
when calculating penalties. This allows for the sameScorer to be used with
different penalty calculation parameters (#2237).DefaultRouteris no longer restrained to aMutex-wrappedScore,
allowing it to be used inno-stdbuilds (#2383).CustomMessageHandler::provided_{node,init}_featuresand various custom
feature bit methods on*Featureswere added (#2204).- Keysend/push payments using MPP are now supported when receiving if
UserConfig::accept_mpp_keysendis set and when sending if specified in the
PaymentParameters. Note that not all recipients support this (#2156). - A new
ConfirmationTarget::MempoolMinimumhas been added (#2415). SpendableOutputDescriptor::to_psbt_inputwas added (#2286).ChannelManager::update_partial_channel_configwas added (#2330).ChannelDetails::channel_shutdown_statewas added (#2347).- The shutdown script can now be provided at shutdown time via
ChannelManager::close_channel_with_feerate_and_script(#2219). BroadcasterInterfacenow takes multiple transactions at once. While not
available today, in the future single calls should be passed to a full node
via a single batch/package transaction acceptance API (#2272).Balance::claimable_amount_satoshiswas added (#2333).payment_{hash,preimage}have been added to someBalancevariants (#2217).- The
lightning::chain::keysinterfaceis nowlightning::sign(#2246). - Routing to a blinded path has been implemented, though sending to such a
route is not yet supported inChannelManager(#2120). OffersMessageHandlerwas added for offers-related onion messages (#2294).- The
CustomMessageHandlerparameter toPeerManagerhas moved to
MessageHandlerfromPeerManager::newexplicitly (#2249). - Various P2P messages for dual funding channel establishment have been added,
though handling for them is not yet inChannelManager(#1794) - Script-fetching methods in
signinterfaces can now return errors, see docs
for the implications of failing (#2213). - The
data_loss_protectoption is now required when reading
channel_reestablishmessages, as many others have done (#2253). InFlightHtlcs::add_inflight_htlchas been added (#2042).- The
initmessagenetworksfield is now written and checked (#2329). PeerManagergenerics have been simplified with the introduction of the
APeerManagertrait (#2249).ParitalOrdandOrdare now implemented forInvoice(#2279).ParitalEqandDebugare now implemented forInMemorySigner(#2328).ParitalEqandEqare now implemented forPaymentError(#2316).NetworkGraph::update_channel_from_announcement_no_lookupwas added (#2222).lightning::routing::gossip::verify_{channel,node}_announcementwas added
(#2307).
Backwards Compatibility
PaymentParameterswritten with blinded path info using LDK 0.0.115 will not
be readable in LDK 0.0.116, and vice versa.- Forwarding less than
Event::HTLCIntercepted::expected_outbound_amount_msat
inChannelManager::forward_intercepted_htlcmay prevent the
ChannelManagerfrom being read by LDK prior to 0.0.116 (#2319) - Setting
ChannelConfig::accept_underpaying_htlcsmay prevent the
ChannelManagerfrom being read by LDK prior to 0.0.116 and un-setting the
parameter between restarts may lead to payment failures (#2319). ChannelManager::create_inbound_payment{,_for_hash}_legacyhas been removed,
removing the ability to create inbound payments which are claimable after
downgrade to LDK 0.0.103 and prior. In the future handling such payments will
also be removed (#2351).- Some fields required by LDK 0.0.103 and earlier are no longer written, thus
deserializing objects written by 0.0.116 with 0.0.103 may now fail (#2351).
Bug Fixes
ChannelDetails::next_outbound_htlc_limit_msatwas made substantially more
accurate and a correspondingnext_outbound_htlc_minimum_msatwas added.
This resolves issues where unpayable routes were generated due to
overestimation of the amount which is payable over one of our channels as
the first hop (#2312).- A rare case where delays in processing
Events generated by
ChannelMonitors could lead to loss of those events in case of an untimely
crash. This could lead to the loss of anEvent::SpendableOutputs(#2369). - Fixed a regression in 0.0.115 which caused
PendingHTLCsForwardableevents
to be missed when processing phantom node receives. This caused such
payments to be delayed until a further, unrelated HTLC came in (#2395). - Peers which are unresponsive to channel messages for several timer ticks are
now disconnected to allow for on-reconnection state machine reset. This
works around some issues in LND prior to 16.3 which can cause channels to
hang and eventually force-close (#2293). ChannelManager::newnow requires the current time (either from a recent
block header or the system clock), ensuring invoices created immediately
after startup aren't already expired (#2372).- Resolved an issue where reading a
ProbabilisticScoreron some platforms
(e.g. iOS) can lead to a panic (#2322). ChannelConfig::max_dust_htlc_exposureis now allowed to scale based on
current fees, and the default has been updated to do so. This substantially
reduces the chance of force-closure due to dust exposure. Note that existing
channels will retain their current value and you may wish to update the
value on your existing channels on upgrade (#2354).PeerManager::process_eventsno longer blocks in any case. This fixes a bug
where reentrancy fromPeerManagerinto user code which eventually calls
process_eventscould lead to a deadlock (#2280).- The persist timing of network graph and scoring in
lightning-background-processorhas been tweaked to provide more reliable
persistence after updates to either (#2226). - The number of route hints added to BOLT 11 invoices by the
lightning-invoice::utilsbuilders has been reduced to three to ensure
invoices can be represented in scan-able QR codes (#2044). - Fixed sending large onion messages, which would previously have resulted in
an HMAC error on the second hop (#2277). - Fixed a memory leak that may occur when a
ChannelManageror
ChannelMonitorisdroped (#2233). - A potential deadlock in calling
NetworkGraph::eqwas resolved (#2284). - Fixed an overflow which prevented disconnecting peers in some minor cases
with more than 31 peers (#2245). - Gossip messages with an unknown chain hash are now ignored (#2230).
- Rapid Gossip Sync processing now fails on an unknown chain hash (#2324).
RouteHintHop::htlc_maximum_msatis now enforced. Note that BOLT11 route
hints do not have such a field so this code is generally unused (#2305).
Security
0.0.116 fixes a denial-of-service vulnerability which is reachable from
untrusted input from channel counterparties if a 0-conf channel exists with
that counterparty.
- A premature
announcement_signaturesmessage from a peer prior to a 0-conf
channel's funding transaction receiving any confirmations would panic in any
version since 0-conf channels were introduced (#2439).
In total, this release features 142 files changed, 21033 insertions, 11066
deletions in 327 commits from 21 authors, in alphabetical order:
- Alec Chen
- Andrei
- Antoine Riard
- Arik Sosman
- Chad Upjohn
- Daniel Granhão
- Duncan Dean
- Elias Rohrer
- Fred Walker
- Gleb Naumenko
- Jeffrey Czyz
- Martin Habovstiak
- Matt Corallo
- Tony Giorgio
- Valentine Wallace
- Vladimir Fomene
- Willem Van Lint
- Wilmer Paulino
- benthecarman
- ff
- henghonglee
v0.0.115
0.0.115 - Apr 24, 2023 - "Rebroadcast the Bugfixes"
API Updates
- The MSRV of the main LDK crates has been increased to 1.48 (#2107).
- Attempting to claim an un-expired payment on a channel which has closed no
longer fails. The expiry time of payments is exposed via
PaymentClaimable::claim_deadline(#2148). payment_metadatais now supported inInvoicedeserialization, sending,
and receiving (via a newRecipientOnionFieldsstruct) (#2139, #2127).Event::PaymentFailednow exposes a failure reason (#2142).- BOLT12 messages now support stateless generation and validation (#1989).
- The
NetworkGraphis now pruned of stale data after RGS processing (#2161). - Max inbound HTLCs in-flight can be changed in the handshake config (#2138).
lightning-transaction-syncfeatureesplora-async-httpswas added (#2085).- A
ChannelPendingevent is now emitted after the initial handshake (#2098). PaymentForwarded::outbound_amount_forwarded_msatwas added (#2136).ChannelManager::list_channels_by_counterpartywas added (#2079).ChannelDetails::feerate_sat_per_1000_weightwas added (#2094).Invoice::fallback_addresseswas added to fetchbitcointypes (#2023).- The offer/refund description is now exposed in
Invoice{,Request}(#2206).
Backwards Compatibility
- Payments sent with the legacy
*_with_routemethods on LDK 0.0.115+ will no
longer be retryable via the LDK 0.0.114-retry_paymentmethod (#2139). Event::PaymentPathFailed::retrywas removed and will always beNonefor
payments initiated on 0.0.115 which fail on an earlier version (#2063).Routes andPaymentParameterswith blinded path information will not be
readable on prior versions of LDK. Such objects are not currently constructed
by LDK, but may be when processing BOLT12 data in a coming release (#2146).- Providing
ChannelMonitorUpdates generated by LDK 0.0.115 to a
ChannelMonitoron 0.0.114 or before may panic (#2059). Note that this is
in general unsupported, and included here only for completeness.
Bug Fixes
- Fixed a case where
process_events_asyncmaypollaFuturewhich has
already completed (#2081). - Fixed deserialization of
u16arrays. This bug may have previously corrupted
the historical buckets in aProbabilisticScorer. Users relying on the
historical buckets may wish to wipe their scorer on upgrade to remove corrupt
data rather than waiting on it to decay (#2191). - The
process_events_asynctask is nowSendand can thus be polled on a
multi-threaded runtime (#2199). - Fixed a missing macro export causing
impl_writeable_tlv_based_enum{,_upgradable}calls to not compile (#2091). - Fixed compilation of
lightning-invoicewith bothno-stdand serde (#2187) - Fix an issue where the
background-processorwould not wake when a
ChannelMonitorUpdatecompleted asynchronously, causing delays (#2090). - Fix an issue where
process_events_asyncwould exit immediately (#2145). Routercalls from theChannelManagernow callfind_route_with_idrather
thanfind_route, as was intended and described in the API (#2092).- Ensure
process_events_asyncalways exits if any sleep future returns true,
not just if all sleep futures repeatedly return true (#2145). channel_updatemessages no longer set the disable bit unless the peer has
been disconnected for some time. This should resolve cases where channels are
disabled for extended periods of time (#2198).- We no longer remove CLN nodes from the network graph for violating the BOLT
spec in some cases after failing to pay through them (#2220). - Fixed a debug assertion which may panic under heavy load (#2172).
CounterpartyForceClosed::peer_msgis now wrapped in UntrustedString (#2114)- Fixed a potential deadlock in
funding_transaction_generated(#2158).
Security
- Transaction re-broadcasting is now substantially more aggressive, including a
new regular rebroadcast feature called on a timer from the
background-processoror fromChainMonitor::rebroadcast_pending_claims.
This should substantially increase transaction confirmation reliability
without relying on downstreamTransactionBroadcasterimplementations for
rebroadcasting (#2203, #2205, #2208). - Implemented the changes from BOLT PRs #1031, #1032, and #1040 which resolve a
privacy vulnerability which allows an intermediate node on the path to
discover the final destination for a payment (#2062).
In total, this release features 110 files changed, 11928 insertions, 6368
deletions in 215 commits from 21 authors, in alphabetical order:
- Advait
- Alan Cohen
- Alec Chen
- Allan Douglas R. de Oliveira
- Arik Sosman
- Elias Rohrer
- Evan Feenstra
- Jeffrey Czyz
- John Cantrell
- Lucas Soriano del Pino
- Marc Tyndel
- Matt Corallo
- Paul Miller
- Steven
- Steven Williamson
- Steven Zhao
- Tony Giorgio
- Valentine Wallace
- Wilmer Paulino
- benthecarman
- munjesi
v0.0.114
0.0.114 - Mar 3, 2023 - "Faster Async BOLT12 Retries"
API Updates
InvoicePayerhas been removed and its features moved directly into
ChannelManager. As such it now requires a simplifiedRouterand supports
send_payment_with_retry(and friends).ChannelManager::retry_paymentwas
removed in favor of the automated retries. Invoice payment utilities in
lightning-invoicenow call the new code (#1812, #1916, #1929, #2007, etc).Sign/BaseSignhas been renamedChannelSigner, withEcdsaChannelSigner
split out in anticipation of future schnorr/taproot support (#1967).- The catch-all
KeysInterfacewas split intoEntropySource,NodeSigner,
andSignerProvider.KeysManagerimplements all three (#1910, #1930). KeysInterface::get_node_secretis nowKeysManager::get_node_secret_key
and is no longer required for external signers (#1951, #2070).- A
lightning-transaction-synccrate has been added which implements keeping
LDK in sync with the chain via an esplora server (#1870). Note that it can
only be used on nodes that never ran a previous version of LDK. Scoreis updated inBackgroundProcessorinstead of viaRouter(#1996).ChainAccess::get_utxo(nowUtxoAccess) can now be resolved async (#1980).- BOLT12
Offer,InvoiceRequest,InvoiceandRefundstructs as well as
associated builders have been added. Such invoices cannot yet be paid due to
missing support for blinded path payments (#1927, #1908, #1926). - A
lightning-custom-messagecrate has been added to make combining multiple
custom messages into one enum/handler easier (#1832). Event::PaymentPathFailureis now generated for failure to send an HTLC
over the first hop on our local channel (#2014, #2043).lightning-net-tokiono longer requires anArconPeerManager(#1968).ChannelManager::list_recent_paymentswas added (#1873).lightning-background-processorstdis now optional in async mode (#1962).create_phantom_invoicecan now be used inno-std(#1985).- The required final CLTV delta on inbound payments is now configurable (#1878)
- bitcoind RPC error code and message are now surfaced in
block-sync(#2057). - Get
historical_estimated_channel_liquidity_probabilitieswas added (#1961). ChannelManager::fail_htlc_backwards_with_reasonwas added (#1948).- Macros which implement serialization using TLVs or straight writing of struct
fields are now public (#1823, #1976, #1977).
Backwards Compatibility
- Any inbound payments with a custom final CLTV delta will be rejected by LDK
if you downgrade prior to receipt (#1878). Event::PaymentPathFailed::network_updatewill always beNoneif an
0.0.114-generated event is read by a prior version of LDK (#2043).Event::PaymentPathFailed::all_paths_removedwill always be false if an
0.0.114-generated event is read by a prior version of LDK. Users who rely on
it to determine payment retries should migrate toEvent::PaymentFailed, in
a separate release prior to upgrading to LDK 0.0.114 if downgrading is
supported (#2043).
Performance Improvements
- Channel data is now stored per-peer and channel updates across multiple
peers can be operated on simultaneously (#1507). - Routefinding is roughly 1.5x faster (#1799).
- Deserializing a
NetworkGraphis roughly 6x faster (#2016). - Memory usage for a
NetworkGraphhas been reduced substantially (#2040). KeysInterface::get_secure_random_bytesis roughly 200x faster (#1974).
Bug Fixes
- Fixed a bug where a delay in processing a
PaymentSentevent longer than the
time taken to persist aChannelMonitorupdate, when occurring immediately
prior to a crash, may result in thePaymentSentevent being lost (#2048). - Fixed spurious rejections of rapid gossip sync data when the graph has been
updated by other means between gossip syncs (#2046). - Fixed a panic in
KeysManagerwhen the high bit ofstarting_time_nanos
is set (#1935). - Resolved an issue where the
ChannelManager::get_persistable_update_future
future would fail to wake until a second notification occurs (#2064). - Resolved a memory leak when using
ChannelManager::send_probe(#2037). - Fixed a deadlock on some platforms at least when using async
ChannelMonitor
updating (#2006). - Removed debug-only assertions which were reachable in threaded code (#1964).
- In some cases when payment sending fails on our local channel retries no
longer take the same path and thus never succeed (#2014). - Retries for spontaneous payments have been fixed (#2002).
- Return an
Erriflightning-persisterfails to read the directory listing
rather than panicing (#1943). peer_disconnectedwill now never be called withoutpeer_connected(#2035)
Security
0.0.114 fixes several denial-of-service vulnerabilities which are reachable from
untrusted input from channel counterparties or in deployments accepting inbound
connections or channels. It also fixes a denial-of-service vulnerability in rare
cases in the route finding logic.
- The number of pending un-funded channels as well as peers without funded
channels is now limited to avoid denial of service (#1988). - A second
channel_readymessage received immediately after the first could
lead to a spurious panic (#2071). This issue was introduced with 0conf
support in LDK 0.0.107. - A division-by-zero issue was fixed in the
ProbabilisticScorerif the amount
being sent (including previous-hop fees) is equal to a channel's capacity
while walking the graph (#2072). The division-by-zero was introduced with
historical data tracking in LDK 0.0.112.
In total, this release features 130 files changed, 21457 insertions, 10113
deletions in 343 commits from 18 authors, in alphabetical order:
- Alec Chen
- Allan Douglas R. de Oliveira
- Andrei
- Arik Sosman
- Daniel Granhão
- Duncan Dean
- Elias Rohrer
- Jeffrey Czyz
- John Cantrell
- Kurtsley
- Matt Corallo
- Max Fang
- Omer Yacine
- Valentine Wallace
- Viktor Tigerström
- Wilmer Paulino
- benthecarman
- jurvis
v0.0.113
0.0.113 - Dec 16, 2022 - "Big Movement Intercepted"
API Updates
ChannelManager::send_paymentnow takes an explicitPaymentIdwhich is a
loose idempotency token. Seesend_paymentdocs for more (#1761, #1826).- HTLCs bound for SCIDs from
ChannelManager::get_intercept_scidare now
intercepted and can be forwarded manually over any channel (#1835, #1893). Confirm::get_relevant_txidsnow returns aBlockHash, expanding the set
of cases wheretransaction_unconfirmedmust be called, see docs (#1796).- Pending outbound payments are no longer automatically timed-out a few blocks
after failure. Thus, in order to avoid leaking memory, you MUST call
ChannelManager::abandon_paymentwhen you no longer wish to retry (#1761). ChannelManager::abandon_paymentdocs were updated to note that the payment
may return to pending after a restart if no persistence occurs (#1907).Event::PaymentReceivedhas been renamedEvent::PaymentClaimable(#1891).Eventhandling is now optionally async for Rust users (#1787).user_channel_idis now au128and random for inbound channels (#1790).- A new
ChannelReadyevent is generated whenever a channel becomes ready to
be used, i.e., after both sides sent thechannel_readymessage (#1743). NetworkGraphnow prunes channels where either node is offline for 2 weeks
and refuses to accept re-announcements of pruned channels (#1735).- Onion messages are now read in
CustomOnionMessageHandlerrather than via
MaybeReadableArgs(#1809). - Added a new util to generate an invoice with a custom hash (#1894) -
create_invoice_from_channelmanager_and_duration_since_epoch_with_payment_hash Signers are now by default re-derived usingKeysInterface's new
derive_channel_signerrather thanread_chan_signer(#1867).Confirm::transactions_confirmedis now idempotent (#1861).ChannelManager::compute_inflight_htlcshas been added to fetch in-flight
HTLCs for scoring. Note thatInvoicePayerdoes this for you (#1830).- Added
PaymentClaimable::via_channel_id(#1856). - Added the
node_id(phantom or regular) to payment events (#1766). - Added the funding transaction
confirmationstoChannelDetails(#1856). BlindedRoutehas been renamedBlindedPath(#1918).- Support for the BOLT 4 "legacy" onion format has been removed, in line with
its removal in the spec and vanishingly rare use (#1413). ChainMonitor::list_pending_monitor_updateswas added (#1834).- Signing for non-zero-fee anchor commitments is supported again (#1828).
- Several helpers for transaction matching and generation are now pub (#1839).
Bug Fixes
- Fixed a rare race where a crash may result in a pending HTLC not being
failed backwards, leading to a force-closure by our counterparty (#1857). - Avoid incorrectly assigning a lower-bound on channel liquidity when routing
fails due to a closed channel earlier in the path (#1817). - If a counterparty increases the channel fee, but not enough per our own fee
estimator, we no longer force-close the channel (#1852). - Several bugs in the
lightning-background-processorfuturefeature were
fixed, including requirements doc corrections (#1843, #1845, #1851). - Some failure messages sent back when failing an HTLC were corrected (#1895).
rapid-gossip-syncno longer errors if an update is applied duplicatively
or in rare cases when the graph is updated from payment failures (#1833).- Sending onion messages to a blinded path in which we're the introduction
node no longer fails (#1791).
Backwards Compatibility
- No
ChannelReadyevents will be generated for previously existing channels,
including those which become ready after upgrading to 0.0.113 (#1743). - Once
UserConfig::accept_intercept_htlcsis set, downgrades to LDK versions
prior to 0.0.113 are not supported (#1835). - Existing payments may see a
PaymentClaimable::user_channel_idof 0 (#1856) - When downgrading to a version of LDK prior to 0.0.113 when there are
resolved payments waiting for a small timeout, the payments may not be
removed, preventing payments with the samePaymentId(#1761).
In total, this release features 76 files changed, 11639 insertions, 6067
deletions in 210 commits from 18 authors, in alphabetical order:
- Antoine Riard
- Arik Sosman
- Devrandom
- Duncan Dean
- Elias Rohrer
- Gleb Naumenko
- Jeffrey Czyz
- John Cantrell
- Matt Corallo
- Tee8z
- Tobin C. Harding
- Tristan F
- Valentine Wallace
- Viktor Tigerström
- Wilmer Paulino
- benthecarman
- jurvis
- ssbright
v0.0.112
0.0.112 - Oct 25, 2022 - "History Matters"
API Updates
Result<(), ChannelMonitorUpdateErr>return values have been replaced with
aChannelMonitorUpdateStatustrinary enum. This better denotes that
ChannelMonitorUpdateStatus::InProgressis not an error, but asynchronous
persistence of a monitor update. Note that asynchronous persistence still
has some edge cases and is not yet recommended for production (#1106).ChannelMonitorpersistence failure no longer automatically broadcasts the
latest commitment transaction. See the
ChannelMonitorUpdateStatus::PermanentFailuredocs for more info (#1106).*Features::knownhas been replaced with individual
*MessageHandler::provided_*_featuresmethods (#1707).OnionMessengernow takes aCustomOnionMessageHandlerimplementation,
allowing you to send and receive custom onion messages (#1748).ProbabilisticScorernow tracks the historical distribution of liquidity
estimates for channels. See newhistorical_*parameters in
ProbabilisticScoringParametersfor more details (#1625).lightning-block-sync'sBlockSourcetrait now supports BIP 157/158
filtering clients by returning only header data for some blocks (#1706).lightning-invoice'sRoutertrait now accepts anInFlightHtlcsto
ensure we do not over-use a remote channel's funds during routing (#1694).
Note that this was previously backported to 0.0.111 for bindings users.NetworkGraph::remove_stale_channelshas been renamed
NetworkGraph::remove_stale_channels_and_trackingasNetworkGraphnow
refuses to re-add nodes and channels that were recently removed (#1649).- The
lightning-rapid-gossip-synccrate now supportsno-std(#1708). - The default
ProbabilisticScoringParameters::liquidity_offset_half_lifehas
been increased to six hours from one (#1754). - All commitment transaction building logic for anchor outputs now assumes the
no-HTLC-tx-fee variant (#1685). - A number of missing
Eqimplementations were added (#1763).
Bug Fixes
lightning-background-processornow builds without error with thefutures
feature (#1744).ChannelManager::get_persistable_update_future's returnedFuturehas been
corrected to not fail to be awoken in some cases (#1758).- Asynchronously performing the initial
ChannelMonitorpersistence is now
safe (#1678). - Redundantly applying rapid gossip sync updates no longer
Errs (#1764). - Nodes which inform us via payment failures that they should no longer be
used are now removed from the network graph. Some LND nodes spuriously
generate this error and may remove themselves from our graph (#1649).
In total, this release features 134 files changed, 6598 insertions, 4370
deletions in 109 commits from 13 authors, in alphabetical order:
- Duncan Dean
- Elias Rohrer
- Gabriel Comte
- Gursharan Singh
- Jeffrey Czyz
- Jurvis Tan
- Matt Corallo
- Max Fang
- Paul Miller
- Valentine Wallace
- Viktor Tigerström
- Wilmer Paulino
- acid-bit