Don't require import of internal macro for impl_writeable_tlv_based
#2506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit f560320 introduced changes that require users of `impl_writeable_tlv_based`/`impl_writeable_tlv_based_enum` to import `_encode_varint_length_prefixed_tlv` and `alloc` separately. Here, we take care of the necessary imports in `_encode_varint_length_prefixed_tlv` itself, allowing users to just import the `impl_writeable_tlv_based` variant they need.
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2506 +/- ##
==========================================
- Coverage 90.39% 90.38% -0.01%
==========================================
Files 106 106
Lines 56269 56268 -1
Branches 56269 56268 -1
==========================================
- Hits 50862 50860 -2
- Misses 5407 5408 +1
☔ View full report in Codecov by Sentry. |
wpaulino
approved these changes
Aug 17, 2023
valentinewallace
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit f560320 introduced changes that require users of
impl_writeable_tlv_based/impl_writeable_tlv_based_enumto import_encode_varint_length_prefixed_tlvandallocseparately.Here, we take care of the necessary imports in
_encode_varint_length_prefixed_tlvitself, allowing users to just import theimpl_writeable_tlv_basedvariant they need.