Fixes bug that causes incorrect conversion of JsonValue to Txid. #2796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug happens when there is a call to a bitcoind that expects a transaction id as a response and results in a corrupted Txid being returned.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2796 +/- ##
==========================================
- Coverage 88.60% 88.57% -0.04%
==========================================
Files 114 114
Lines 91574 91573 -1
Branches 91574 91573 -1
==========================================
- Hits 81139 81109 -30
- Misses 7957 7979 +22
- Partials 2478 2485 +7 ☔ View full report in Codecov by Sentry. |
TheBlueMatt
approved these changes
Dec 15, 2023
Collaborator
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
Huh, I guess we don't actually use this code in LDK itself?
wpaulino
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug happens when there is a call to a bitcoind that expects a transaction id as a response and results in a corrupted Txid being returned.