Expose parse_onion_address publicly in no-std
#2633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for having a separate `parse_onion_address` from `FromStr` is to have an onion parsing function in `no-std`, but when we added it we forgot to make it public. We do this here, as well as fix a few compilation warnings in `no-std`.
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2633 +/- ##
==========================================
- Coverage 89.09% 89.05% -0.05%
==========================================
Files 112 112
Lines 86932 86932
Branches 86932 86932
==========================================
- Hits 77456 77421 -35
- Misses 7246 7273 +27
- Partials 2230 2238 +8
☔ View full report in Codecov by Sentry. |
jbesraa
approved these changes
Oct 1, 2023
valentinewallace
approved these changes
Oct 3, 2023
jkczyz
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for having a separate
parse_onion_addressfromFromStris to have an onion parsing function inno-std, but when we added it we forgot to make it public. We do this here, as well as fix a few compilation warnings inno-std.