Fix skimmed fee serialization in Channel
#2735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
LGTM |
Previously, if some holding cell HTLCs have skimmed fees present and some don't, we would fail to deserialize a Channel. See added test coverage.
valentinewallace
force-pushed
the
2023-11-skimmed-fee-ser
branch
from
57498a1 to
633be23
Compare
Contributor
Author
|
Rebased. |
TheBlueMatt
approved these changes
Dec 4, 2023
Collaborator
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
I'm fine with the simpler code, but we could also fix it with just replacing the for _ in 0..idxs with for _ in 1..idx.
Collaborator
|
Gonna go ahead and land this. The excess few bytes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if some holding cell HTLCs had skimmed fees present and some
didn't, we would fail to deserialize a
Channel. See added test coverage. Indirectly pointed out by Matt here.Just the last commit. Based on #2540 for ease of testing.