Derive a PartialEq and Eq for PaymentError #2316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2316 +/- ##
==========================================
- Coverage 90.87% 90.79% -0.08%
==========================================
Files 104 104
Lines 52926 53033 +107
Branches 52926 53033 +107
==========================================
+ Hits 48094 48153 +59
- Misses 4832 4880 +48
☔ View full report in Codecov by Sentry. |
tnull
reviewed
May 24, 2023
benthecarman
force-pushed
the
payment-err-dervies
branch
from
f20e435 to
c34bccd
Compare
benthecarman
changed the title
tnull
reviewed
May 24, 2023
This lets users compare error types more easily without needing a match statement.
benthecarman
force-pushed
the
payment-err-dervies
branch
from
c34bccd to
3003f7d
Compare
tnull
approved these changes
May 25, 2023
tnull
reviewed
May 25, 2023
wpaulino
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets users compare error types more easily without needing a match
statement.