Add dry-run functionality for WorkspaceKind creation #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bhakti Narvekar <[email protected]>
Signed-off-by: paulovmr <[email protected]>
Signed-off-by: paulovmr <[email protected]>
) Signed-off-by: Jenny <[email protected]> add icon to workspaceKindsColumns interface fix actions cell alignment move card title to fix spacing
…flow#419) Signed-off-by: Jenny <[email protected]>
Signed-off-by: paulovmr <[email protected]>
Signed-off-by: paulovmr <[email protected]>
…nd it (kubeflow#415) * Minor refactorings and initial work for the Workspace Kind summary page Signed-off-by: Guilherme Caponetto <[email protected]> * feat(ws): added links from workspace kind details drawer to workspace kinds details page (kubeflow#1) Signed-off-by: Paulo Rego <[email protected]> * Enable workspace filtering by namespace in the WorkspaceKind summary page Signed-off-by: Guilherme Caponetto <[email protected]> * Update Pause/Start action response types according to backend Signed-off-by: Guilherme Caponetto <[email protected]> * Fix WorkspaceKind logo href Signed-off-by: Guilherme Caponetto <[email protected]> * Replace placeholders for GPU data with real values in WorkspaceKind summary page Signed-off-by: Guilherme Caponetto <[email protected]> * Allow columns to be hidden in the WorkspaceTable Signed-off-by: Guilherme Caponetto <[email protected]> * feat(ws): added links from workspace kind details drawer namespace tab to workspace kinds details page (kubeflow#2) Signed-off-by: Paulo Rego <[email protected]> * Improve types around Filter component Signed-off-by: Guilherme Caponetto <[email protected]> * feat: Add Workspace Actions Context and related components - Introduced WorkspaceActionsContext to manage workspace actions such as view, edit, delete, start, restart, and stop. - Created WorkspaceActionsContextProvider to encapsulate the context logic and provide it to child components. - Implemented WorkspaceKindSummary and Workspaces components to utilize the new context for handling workspace actions. - Added polling for refreshing workspaces at a default interval. - Enhanced WorkspaceTable to support row actions for workspaces. - Updated various components to include sortable and filterable data fields. - Refactored WorkspaceStartActionModal and WorkspaceStopActionModal to handle optional onActionDone callback. - Added loading and error handling components for better user experience. Signed-off-by: Guilherme Caponetto <[email protected]> * feat: Add buildWorkspaceList function and integrate into mockAllWorkspaces Signed-off-by: Guilherme Caponetto <[email protected]> * refactor: Update mock data and formatting for workspace activity timestamps Signed-off-by: Guilherme Caponetto <[email protected]> * feat: Implement usePolling hook and refactor workspace actions in Workspaces and WorkspaceKindSummary components Signed-off-by: Guilherme Caponetto <[email protected]> * refactor: Update column key usage in ExpandedWorkspaceRow and adjust workspace actions visibility in Workspaces component Signed-off-by: Guilherme Caponetto <[email protected]> * Make mocked workspace list deterministic Signed-off-by: Guilherme Caponetto <[email protected]> * feat: Enhance WorkspaceTable with additional columns and filtering capabilities - Added 'namespace', 'gpu', and 'idleGpu' columns to WorkspaceTable. - Updated filtering logic to support new columns in WorkspaceTable. - Refactored useWorkspaces hook to remove unnecessary parameters related to idle and GPU filtering. - Modified WorkspaceKindSummary and its expandable card to utilize new filtering functionality. - Updated WorkspaceUtils to include a method for formatting workspace idle state. - Adjusted Filter component to support generic filtered column types. - Updated Workspaces page to hide new columns as needed. Signed-off-by: Guilherme Caponetto <[email protected]> * refactor: Improve sorting functionality in WorkspaceTable by utilizing specific types for sortable columns Signed-off-by: Guilherme Caponetto <[email protected]> * Adjustments after rebase Signed-off-by: Guilherme Caponetto <[email protected]> * Format with prettier Signed-off-by: Guilherme Caponetto <[email protected]> --------- Signed-off-by: Guilherme Caponetto <[email protected]> Signed-off-by: Paulo Rego <[email protected]> Co-authored-by: Paulo Rego <[email protected]>
…w#438) Signed-off-by: paulovmr <[email protected]>
* Add routes for Workspace Kind Create Signed-off-by: Charles Thao <[email protected]> * Implement method selection step for Workspace Kind Create wizard Signed-off-by: Charles Thao <[email protected]> * Add styling Signed-off-by: Charles Thao <[email protected]> * Add type guards for yaml file upload Signed-off-by: Charles Thao <[email protected]> * Add properties step to WorkspaceKindForm Signed-off-by: Charles Thao <[email protected]> * Add image step to WorkspaceKindForm Signed-off-by: Charles Thao <[email protected]> * Add empty steps and switch Method step to radio buttons Signed-off-by: Charles Thao <[email protected]> * Add step description to Workspace Kind Form Signed-off-by: Charles Thao <[email protected]> * Migrate Workspace Kind Form to utilize Toggle Group Signed-off-by: Charles Thao <[email protected]> * Disable Form View when YAML is not uploaded or valid Signed-off-by: Charles Thao <[email protected]> * Allow VScode to discover local ESLint rules Signed-off-by: Charles Thao <[email protected]> * Styling organization improvements + Refactor types Signed-off-by: Charles Thao <[email protected]> --------- Signed-off-by: Charles Thao <[email protected]>
Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
…w#424) * feat(ws): Clean and fix swagger warnings and errors Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> * feat(ws): Clean and fix swagger warnings and errors Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> --------- Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> Co-authored-by: Liav Weiss (EXT-Nokia) <[email protected]>
…flow#396) Signed-off-by: Jiri Daněk <[email protected]>
Given we have migrated all our images from docker.io to ghcr.io - our `notebooks-v2` branch should reference the "proper" container registry. This commit updates the code to use: - `ghcr.io/kubeflow/kubeflow/notebook-servers` Affected areas: - `jupyterlab_scipy_180` and `jupyterlab_scipy_190` `imageConfig` entries - various test files Signed-off-by: Andy Stoneberg <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
* feat(ws): Properly containerize backend component kubeflow#323 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> * feat(ws): Properly containerize backend component kubeflow#323 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> * feat(ws): Properly containerize backend component kubeflow#323 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> * mathew: revert typo Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> Signed-off-by: Mathew Wicks <[email protected]> Co-authored-by: Liav Weiss (EXT-Nokia) <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: Charles Thao <[email protected]>
Signed-off-by: Charles Thao <[email protected]>
…w#452) Signed-off-by: Jenny <[email protected]> Changes to step descriptions based on feedback
* Add Pod Config to WorkspaceKind form Signed-off-by: Charles Thao <[email protected]> * Add resource section for PodConfig Signed-off-by: Charles Thao <[email protected]> * Use refactored types Signed-off-by: Charles Thao <[email protected]> * Improve Resource input Signed-off-by: Charles Thao <[email protected]> * Move form view to edit mode only Signed-off-by: Charles Thao <[email protected]> * Bug fix and improvements Signed-off-by: Charles Thao <[email protected]> --------- Signed-off-by: Charles Thao <[email protected]>
Signed-off-by: DominikKawka <[email protected]>
* feat(ws): Notebooks 2.0 // Backend // API that allows frontend to upload a YAML file containing a full new WorkspaceKind definition Signed-off-by: Asaad Balum <[email protected]> * mathew: 1 Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Asaad Balum <[email protected]> Signed-off-by: Mathew Wicks <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
… creation (kubeflow#471) * feat(ws): prepare frontend for validation errors during WorkspaceKind creation Signed-off-by: Guilherme Caponetto <[email protected]> * feat(ws): extract validation alert to its own component Signed-off-by: Guilherme Caponetto <[email protected]> * fix(ws): use error icon for helper text Signed-off-by: Guilherme Caponetto <[email protected]> --------- Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: paulovmr <[email protected]>
Signed-off-by: paulovmr <[email protected]>
…flow#432) Signed-off-by: Jenny <[email protected]> add icon to workspaceKindsColumns interface fix(ws): Update table with expandable variant and fix styles fix secondary border in menu toggle fix menu toggle expanded text color and update icon to use status prop remove unused files add cluster storage description list group Signed-off-by: Jenny <[email protected]> Add title and packages revert form label styling, revert homeVol column fix linting fix lint Signed-off-by: Jenny <[email protected]> Add PR code suggestions, remove unused interfaces Signed-off-by: Jenny <[email protected]> remove unused import Signed-off-by: Jenny <[email protected]> fix filterWorkspacesTest Signed-off-by: Jenny <[email protected]> fix(ws): apply feedback to fix Cypress tests Signed-off-by: Jenny <[email protected]> Update tests, add width to defineDataFields, remove duplicate WorkspaceTableColumnKeys type Signed-off-by: Jenny <[email protected]> fix wrapping behavior Signed-off-by: Jenny <[email protected]> Replace Th values with mapped instance Signed-off-by: Jenny <[email protected]> revert column order Signed-off-by: Jenny <[email protected]> remove hardcoded package label instances Signed-off-by: Jenny <[email protected]> delete cursor rule
) Signed-off-by: paulovmr <[email protected]>
Signed-off-by: Charles Thao <[email protected]>
Signed-off-by: paulovmr <[email protected]>
Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: Jenny <[email protected]>
Signed-off-by: paulovmr <[email protected]>
* feat(ws): Define k8s workload manifest for backend component kubeflow#324 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> * feat(ws): Define k8s workload manifest for backend component kubeflow#324 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> * feat(ws): add Istio AuthorizationPolicy for nb-backend kubeflow#324 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> * feat(ws): Define k8s workload manifest for backend component + istio - kubeflow#324 Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> --------- Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]> Co-authored-by: Liav Weiss (EXT-Nokia) <[email protected]>
* feat(ws): Define k8s workload manifest for frontend component kubeflow#404 Signed-off-by: Noa <[email protected]> * fix: virtual-service tweaks from review Signed-off-by: Andy Stoneberg <[email protected]> --------- Signed-off-by: Noa <[email protected]> Signed-off-by: Andy Stoneberg <[email protected]> Co-authored-by: Andy Stoneberg <[email protected]>
Signed-off-by: Guilherme Caponetto <[email protected]>
…for frontend changes (kubeflow#549) Signed-off-by: Guilherme Caponetto <[email protected]>
* feat(ws): frontend Makefile to support deploy Signed-off-by: CI Bot <[email protected]> * mathew: fix 1 Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: CI Bot <[email protected]> Signed-off-by: Mathew Wicks <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
Signed-off-by: Guilherme Caponetto <[email protected]>
- Implement dry-run parameter handling in workspacekinds handler - Update repository layer to support dry-run - Add comprehensive test cases for dry-run functionality Fixes kubeflow#417
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
added
area/ci
Signed-off-by: bhaktinarvekar <[email protected]>
|
/close this appears to be a duplicate of #598 |
|
@andyatmiami: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.