feat: refactor Form View to Edit only #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaorell
changed the title
thaorell
force-pushed
the
notebooks-v2-workspace-kind-creation-refactor
branch
2 times, most recently
from
1c74bc7 to
258a134
Compare
Signed-off-by: Charles Thao <[email protected]>
Screen.Recording.2025-06-27.at.1.48.22.PM.mov |
thaorell
force-pushed
the
notebooks-v2-workspace-kind-creation-refactor
branch
from
258a134 to
bd6a9c9
Compare
google-oss-prow
bot
added
area/frontend
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ederign
approved these changes
Jun 27, 2025
|
/ok-to-test |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
6 tasks
bhaktinarvekar
pushed a commit
to bhaktinarvekar/notebooks
that referenced
this pull request
Sep 14, 2025
Signed-off-by: Charles Thao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #349
related: #365
Per the community meeting on June 26th 2025, the team has come to an agreement that the creation flow should allow only a single YAML upload. Configuring pod config, properties and images will only be available when the user wishes to Edit a Workspace Kind