feat(ws): prepare frontend for validation errors during WorkspaceKind creation #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… creation Signed-off-by: Guilherme Caponetto <[email protected]>
google-oss-prow
bot
added
area/frontend
|
/ok-to-test |
Signed-off-by: Guilherme Caponetto <[email protected]>
Signed-off-by: Guilherme Caponetto <[email protected]>
ederign
approved these changes
Jul 7, 2025
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
noalimoy
pushed a commit
to noalimoy/notebooks
that referenced
this pull request
Jul 17, 2025
… creation (kubeflow#471) * feat(ws): prepare frontend for validation errors during WorkspaceKind creation Signed-off-by: Guilherme Caponetto <[email protected]> * feat(ws): extract validation alert to its own component Signed-off-by: Guilherme Caponetto <[email protected]> * fix(ws): use error icon for helper text Signed-off-by: Guilherme Caponetto <[email protected]> --------- Signed-off-by: Guilherme Caponetto <[email protected]>
bhaktinarvekar
pushed a commit
to bhaktinarvekar/notebooks
that referenced
this pull request
Sep 14, 2025
… creation (kubeflow#471) * feat(ws): prepare frontend for validation errors during WorkspaceKind creation Signed-off-by: Guilherme Caponetto <[email protected]> * feat(ws): extract validation alert to its own component Signed-off-by: Guilherme Caponetto <[email protected]> * fix(ws): use error icon for helper text Signed-off-by: Guilherme Caponetto <[email protected]> --------- Signed-off-by: Guilherme Caponetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #454
Also in this PR:
<FileUpload>.dropzonePropsto block invalid file extensions inWorkspaceKindFormupload<Alert>title bold againDemo:
issue454.mov