chore: add OWNERS files with reviewers and labels #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathew Wicks <[email protected]>
|
/lgtm pair-programmed with @thesuperzapper one the construction of this PR... excited about the changes. |
|
/ok-to-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit ca3289c
into
kubeflow:notebooks-v2
12 of 13 checks passed
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
|
Ok, it turns out that Kubeflow's prow does not have the |
This was referenced Sep 11, 2025
bhaktinarvekar
pushed a commit
to bhaktinarvekar/notebooks
that referenced
this pull request
Sep 14, 2025
Signed-off-by: Mathew Wicks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that our up-and-coming approvers (@andyatmiami - controller, backend /// @paulovmr - frontend) are automatically assigned as a reviewer in their respective areas.
This is in line with the code review process that should enable people to get to approver once they consistently lgtm PRs in a state which the approvers would have merged.
Additionally, it seems like we can set
labelsin theOWNERSfiles which should automatically apply those labels to PRs which change code under those paths. Hopefully this works, but we will see after we merge.