feat(ws): add fallback mechanism to broken images #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @paulovmr |
Signed-off-by: Guilherme Caponetto <[email protected]>
caponetto
force-pushed
the
handle-broken-images
branch
from
6145c34 to
961892b
Compare
|
/ok-to-test |
ederign
approved these changes
Jun 27, 2025
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
bhaktinarvekar
pushed a commit
to bhaktinarvekar/notebooks
that referenced
this pull request
Sep 14, 2025
Signed-off-by: Guilherme Caponetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some logo or icon URLs provided by the backend may point to invalid or unreachable resources. This PR introduces a fallback mechanism to gracefully handle image loading failures, preventing broken image icons from being displayed in the UI.
Before:
After:
Loading state
Screen.Recording.2025-06-26.at.10.51.31.AM.mov
Error state
Screen.Recording.2025-06-26.at.10.54.17.AM.mov