This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[flutter_release] Flutter 1.22.5 engine cherry-pick #22931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.22-candidate.12. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
flutter-dashboard
bot
changed the base branch from
flutter-1.22-candidate.12
to
master
gspencergoog
changed the base branch from
master
to
flutter-1.22-candidate.12
christopherfujino
changed the title
christopherfujino
changed the title
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
Code LGTM, just waiting on CI to finish to approve and merge.
christopherfujino
approved these changes
Dec 8, 2020
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM, all failures known and documented in description, merging.
This was referenced Dec 8, 2020
christopherfujino
added a commit
that referenced
this pull request
Dec 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous build
Description
Fixes merge conflicts and cherrypicks b4d4e30 into this release branch.
Related PRs in the same release: #22930 and #22938
Known Presubmit Failures
Known Postsubmit Failures