Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Nov 11, 2020

previous build

Scheduled Cherrypicks

Known Presubmit Failures

Known Postsubmit Failures

@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-1.22-candidate.12 to master November 11, 2020 21:47
@flutter-dashboard
Copy link

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.22-candidate.12. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@christopherfujino christopherfujino changed the base branch from master to flutter-1.22-candidate.12 November 11, 2020 21:51
Copy link

@pcsosinski pcsosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for branch

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on fb72023 and 122f242

@LongCatIsLooong
Copy link
Contributor

3f27800 LGTM

@christopherfujino
Copy link
Contributor Author

All outstanding CI failures accounted for in description (and they're the same as the previous build), so merging this.

@christopherfujino christopherfujino merged commit bba39d2 into flutter:flutter-1.22-candidate.12 Nov 12, 2020
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.22-candidate.12 branch November 12, 2020 17:49
@christopherfujino
Copy link
Contributor Author

christopherfujino commented Nov 12, 2020

This PR required a follow-up fix, #22478

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants