Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Nov 12, 2020

Description

Fixes

../../flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsTest.mm:585:35: error: no member named 'IOSSurfaceFactory' in namespace 'flutter'
  auto surface_factory = flutter::IOSSurfaceFactory::Create(flutter::IOSRenderingAPI::kSoftware);
                         ~~~~~~~~~^
1 error generated.
ninja: build stopped: subcommand failed.

This is caused because fb72023 depends on 6a3b5fe, and 6a3b5fe is not cherry-picked.

This fix is to use the old API instead of the new api introduced in 6a3b5fe

Related Issues

release

Tests

I added the following tests:

N/A

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-1.22-candidate.12 to master November 12, 2020 21:46
@flutter-dashboard
Copy link

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.22-candidate.12. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

mkdir -p $FRAMEWORK_PATH
cd $FRAMEWORK_PATH
git clone https://github.com/flutter/flutter.git
git clone https://github.com/flutter/flutter.git -b flutter-1.22-candidate.12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@cyanglaz cyanglaz changed the base branch from master to flutter-1.22-candidate.12 November 12, 2020 21:47
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz added waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. and removed waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. labels Nov 12, 2020
@christopherfujino christopherfujino merged commit 2c956a3 into flutter:flutter-1.22-candidate.12 Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants