Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

added unit tests to the rasterizer #22282

Merged
merged 6 commits into from
Nov 4, 2020
Merged

added unit tests to the rasterizer #22282

merged 6 commits into from
Nov 4, 2020

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Nov 4, 2020

Description

I added tests to the rasterizer to help support the landing of #22275

Related Issues

#22275

Tests

I added the following tests:

unit tests for the rasterizer

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@google-cla google-cla bot added the cla: yes label Nov 4, 2020
@gaaclarke gaaclarke requested a review from cyanglaz November 4, 2020 00:36
cyanglaz
cyanglaz approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gaaclarke gaaclarke added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 4, 2020
@gaaclarke
Copy link
Member Author

gaaclarke commented Nov 4, 2020 •
edited
Loading

Landing on red. The failures were infra failures and this is low risk since it just affects test targets.

@gaaclarke gaaclarke merged commit 122f242 into flutter:master Nov 4, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 5, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2020
@engine-flutter-autoroll
122f242 added unit tests to the rasterizer (flutter/engine#22282)
a1ed27e
This was referenced Nov 5, 2020
Merged
Closed
christopherfujino added a commit that referenced this pull request Nov 12, 2020
@christopherfujino @LongCatIsLooong @gaaclarke
[flutter_releases] Flutter 1.22.4 engine cherrypicks (#22449)
bba39d2 
* Update 1.22 engine to use Dart 2.10.4
* [iOS TextInput] Avoid Unnecessary UndateEditingClient Calls (#21303)
* added unit tests to the rasterizer (#22282)
* Reland "Do not involve external_view_embedder in submit frame process if threads are not merged. #22275" (#22372)

Co-authored-by: LongCatIsLooong <[email protected]>
Co-authored-by: gaaclarke <[email protected]>
Co-authored-by: Chris Yang <[email protected]>
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
@gaaclarke @chaselatta
added unit tests to the rasterizer (flutter#22282)
2429a68
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gaaclarke @cyanglaz