Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland "Do not involve external_view_embedder in submit frame process if threads are not merged. #22275" #22372

Merged
merged 3 commits into from
Nov 7, 2020
Merged

Reland "Do not involve external_view_embedder in submit frame process if threads are not merged. #22275" #22372

merged 3 commits into from
Nov 7, 2020

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Nov 6, 2020

Relands #22275

Since 0d5f2e9 was reverted, this re-land doesn't include the conflicts resolving the original PR had.

Fixes flutter/flutter#69449

cbracken
cbracken approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgm based on previous lgtm for #22275.

@cyanglaz cyanglaz added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 6, 2020
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Nov 7, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Android AOT Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux Android Debug Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux Android Scenarios has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux Fuchsia has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac iOS Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite build_and_test_linux_unopt_debug has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 7, 2020
@cyanglaz cyanglaz added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 7, 2020
@fluttergithubbot fluttergithubbot merged commit fb72023 into flutter:master Nov 7, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 7, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 7, 2020
@engine-flutter-autoroll
fb72023 Reland "Do not involve external_view_embedder in submit frame…
6807123 
… process if threads are not merged. flutter#22275" (flutter/engine#22372)
@cyanglaz cyanglaz deleted the reland branch November 7, 2020 15:25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 7, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 7, 2020
@engine-flutter-autoroll
fb72023 Reland "Do not involve external_view_embedder in submit frame…
1dcea89 
… process if threads are not merged. flutter#22275" (flutter/engine#22372)
This was referenced Nov 8, 2020
Closed
Closed
christopherfujino added a commit that referenced this pull request Nov 12, 2020
@christopherfujino @LongCatIsLooong @gaaclarke
[flutter_releases] Flutter 1.22.4 engine cherrypicks (#22449)
bba39d2 
* Update 1.22 engine to use Dart 2.10.4
* [iOS TextInput] Avoid Unnecessary UndateEditingClient Calls (#21303)
* added unit tests to the rasterizer (#22282)
* Reland "Do not involve external_view_embedder in submit frame process if threads are not merged. #22275" (#22372)

Co-authored-by: LongCatIsLooong <[email protected]>
Co-authored-by: gaaclarke <[email protected]>
Co-authored-by: Chris Yang <[email protected]>
@cyanglaz cyanglaz mentioned this pull request Nov 16, 2020
Closed
@Sunbreak Sunbreak mentioned this pull request Nov 17, 2020
Closed
This was referenced Nov 17, 2020
Closed
Closed
@cyanglaz cyanglaz mentioned this pull request Nov 17, 2020
Closed
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
@chaselatta
Reland "Do not involve external_view_embedder in submit frame process…
68689fb 
… if threads are not merged. flutter#22275" (flutter#22372)
@hisaichi5518 hisaichi5518 mentioned this pull request Jan 2, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cbracken cbracken cbracken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-ios waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

platform views on by default introduced a race condition

4 participants

@cyanglaz @fluttergithubbot @cbracken @googlebot