This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix double delete on backspace on Android #22626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspencergoog
changed the title
|
Waiting for merge code |
gspencergoog
requested review from
goderbauer
and removed request for
justinmc
goderbauer
approved these changes
Nov 20, 2020
| assertNull(testImm.lastCursorAnchorInfo); | ||
| } | ||
|
|
||
| @Test |
Member
There was a problem hiding this comment.
Should we add a test to verify that KeyEvent.KEYCODE_DEL doesn't do anything?
Contributor
Author
There was a problem hiding this comment.
OK, I'll add that. Should be a simple matter of reversing the expects in the original test.
gspencergoog
added
the
waiting for tree to go green
pcsosinski
pushed a commit
to pcsosinski/engine
that referenced
this pull request
Nov 23, 2020
pcsosinski
pushed a commit
that referenced
this pull request
Nov 23, 2020
Co-authored-by: Greg Spencer <[email protected]>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 24, 2020
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
gspencergoog
added a commit
to gspencergoog/engine
that referenced
this pull request
Dec 8, 2020
christopherfujino
pushed a commit
that referenced
this pull request
Dec 8, 2020
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This disables the delete handling on the engine side, since now that we send events to the framework first, the framework is handling it.
Related Issues
Tests
Breaking Change