Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Dec 10, 2020

Description

Revert "Fix double delete on backspace on Android (#22626) (#22931)"

This reverts commit d4c0f5e, which was mistakenly cherry picked to this release branch.

The Cirrus web_tests are failing due to using the latest framework commit, rather than the branch point.

HansMuller
HansMuller previously approved these changes Dec 10, 2020
Copy link

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino changed the base branch from master to flutter-1.22-candidate.12 December 10, 2020 00:22
@flutter-dashboard
Copy link

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.22-candidate.12. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-1.22-candidate.12 to master December 10, 2020 00:22
@christopherfujino christopherfujino changed the base branch from master to flutter-1.22-candidate.12 December 10, 2020 00:22
@HansMuller HansMuller dismissed their stale review December 10, 2020 00:23

I approve reverting d4c0f5e but there seems to be more in this PR than that

Copy link

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

@christopherfujino christopherfujino merged commit ae90085 into flutter:flutter-1.22-candidate.12 Dec 10, 2020
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.22-candidate.12 branch December 10, 2020 00:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants