Skip to content

Conversation

@javanna
Copy link
Member

@javanna javanna commented Mar 29, 2019

Opening this PR for a CI run, it includes the following changes that need to be back-ported to 7.x:
#40222
#38154
#38305
#39606
#38152
#40038
#40521
#39789
#40319

krisds and others added 9 commits March 29, 2019 08:14
…stic#40222)

IOException are never thrown in any of the existing pipeline aggregation
builders. Removing the throws IOException from the create method allows
to remove it also from a couple of other methods which ends up simplifying
 AggregationPhase (one less catch).
We recently introduced the option to minimize network roundtrips when
executing cross-cluster search requests. All the changes made around
that are separately unit tested, and there are some yaml tests that
exercise the new code-path which involves multiple coordination steps.
This commit adds new integration tests that compare the output given by
CCS when running the same queries using the two different execution
modes available.

Relates to elastic#32125
"no indices exist" has been added to the error message for absence of indices
I have been hitting the suite timeout on `DocsClientYamlTestSuiteIT`
As far as I can see, the docs tests are taking quite a while, I assume
it's because more and more docs snippets get added over time, which
means more tests. The current suite timeout is the default 20 minutes.
It takes me just a little less than 20 minutes to run these on my
laptop. On my CI, I end up hitting the suite timeout. Hereby I propose
that we increase the suite timeout to 30 minutes.
As part of elastic#40177 we have added top-level pipeline aggs to
`InternalAggregations`. Given that `QuerySearchResult` holds an
`InternalAggregations` instance, there is no need to keep on setting
top-level pipeline aggs separately. Top-level pipeline aggs can then
always be transported through `InternalAggregations`. Such change is
made in a backwards compatible manner.
@javanna
Copy link
Member Author

javanna commented Mar 29, 2019

run elasticsearch-ci/bwc

@javanna
Copy link
Member Author

javanna commented Mar 29, 2019

Build was green, I merged this from command line to preserve all of the different commits.

@javanna javanna closed this Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants