Contradictory type checks (in Debug) #38154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-search |
Contributor
|
@costin can you take a look ? |
Member
|
Good catch - the interface type check should be reversed. |
Member
|
test this please |
Member
|
hi @krisds would you mind merging master in please? We have fixed a number of test failures so that should help getting tests green here. |
Member
|
retest this please |
Member
|
retest this please |
javanna
approved these changes
Mar 20, 2019
Member
|
thanks @krisds ! |
javanna
pushed a commit
to javanna/elasticsearch
that referenced
this pull request
Mar 29, 2019
javanna
pushed a commit
that referenced
this pull request
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested, I will split #38033 into separate PRs. Here is the final part.
This one resolves: