Skip to content

Improve error message for absence of indices #39789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 27, 2019
Merged

Improve error message for absence of indices #39789

merged 8 commits into from
Mar 27, 2019

Conversation

@Eunovo
Copy link
Contributor

@Eunovo Eunovo commented Mar 7, 2019 •
edited by javanna
Loading

"no indices exist" as been added to the error message for absence of indices

closes #38964 replaces #39296

@javanna javanna changed the title Improved error message for absence of indices (closes #38964) Improve error message for absence of indices Mar 7, 2019
@javanna javanna added the :Data Management/Indices APIs APIs to create and manage indices and templates label Mar 7, 2019
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 7, 2019

Pinging @elastic/es-core-features

@javanna
Copy link
Member

javanna commented Mar 7, 2019

test this please

@javanna
Copy link
Member

javanna commented Mar 8, 2019

retest this please

javanna
javanna requested changes Mar 8, 2019
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment, LGTM otherwise, thanks @Eunovo !

javanna
javanna approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left two minor nits around formatting, LGTM otherwise. Thanks a lot @Eunovo

@javanna
Copy link
Member

javanna commented Mar 12, 2019

retest this please

@javanna
Copy link
Member

javanna commented Mar 12, 2019

run elasticsearch-ci/bwc

@Eunovo
Copy link
Contributor Author

Eunovo commented Mar 12, 2019

@javanna I don't understand the last test failure. I don't see how my changes caused this error

@javanna
Copy link
Member

javanna commented Mar 13, 2019

@Eunovo test failures are unrelated to your change, could you please merge master in?

@Eunovo
Copy link
Contributor Author

Eunovo commented Mar 13, 2019 •
edited
Loading

@javanna by " merge master in " do you mean that I should merge elastic:master into Eunovo:master?

@javanna
Copy link
Member

javanna commented Mar 13, 2019

yea so pull latest master in your local master branch, then move to your PR branch and do git merge master, then push again ;)

@javanna
Copy link
Member

javanna commented Mar 14, 2019

@Eunovo I can take care of it if that helps ;)

@Eunovo
Copy link
Contributor Author

Eunovo commented Mar 14, 2019

Yeah, please do @javanna thanks

@javanna
Copy link
Member

javanna commented Mar 18, 2019

retest this please

javanna
javanna approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Eunovo, thanks again. Tests are green now, I reviewed your change and left a tiny comment, if you could address that I can then merge it in.

@javanna
Copy link
Member

javanna commented Mar 21, 2019

retest this please

2 similar comments
@javanna
Copy link
Member

javanna commented Mar 21, 2019

retest this please

@javanna
Copy link
Member

javanna commented Mar 21, 2019

retest this please

@javanna
Copy link
Member

javanna commented Mar 21, 2019

run elasticsearch-ci/bwc

@javanna
Copy link
Member

javanna commented Mar 21, 2019

run elasticsearch-ci/default-distro

@Eunovo
Copy link
Contributor Author

Eunovo commented Mar 22, 2019

@javanna I see lots of failures in the last test, are these related to my changes?

@javanna
Copy link
Member

javanna commented Mar 22, 2019

@Eunovo I don't think so, test infra related, don't worry I will take care of it and merge your PR once ready.

@Eunovo
Copy link
Contributor Author

Eunovo commented Mar 22, 2019 via email •
edited
Loading

@javanna
Copy link
Member

javanna commented Mar 25, 2019

run elasticsearch-ci/bwc elasticsearch-ci/default-distro

@javanna
Copy link
Member

javanna commented Mar 25, 2019

run elasticsearch-ci/default-distro

@javanna
Copy link
Member

javanna commented Mar 26, 2019

retest this please

@javanna javanna merged commit de4704b into elastic:master Mar 27, 2019
@javanna
Copy link
Member

javanna commented Mar 27, 2019

Thanks @Eunovo sorry it took a while to get your PR merged.

@Eunovo
Copy link
Contributor Author

Eunovo commented Mar 28, 2019

No problem, thanks for your help @javanna

javanna pushed a commit to javanna/elasticsearch that referenced this pull request Mar 29, 2019
@Eunovo @javanna
Improve error message for absence of indices (elastic#39789)
32ebf17 
"no indices exist" has been added to the error message for absence of indices
@javanna javanna mentioned this pull request Mar 29, 2019
Closed
javanna pushed a commit that referenced this pull request Mar 29, 2019
@Eunovo @javanna
Improve error message for absence of indices (#39789)
444b4c4 
"no indices exist" has been added to the error message for absence of indices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javanna javanna javanna approved these changes

Assignees

No one assigned

Labels

:Data Management/Indices APIs APIs to create and manage indices and templates >enhancement v7.2.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot apply settings to all indices

4 participants

@Eunovo @elasticmachine @javanna @jakelandis