Improved error message for absence of indices closes #38964 #39296

Eunovo · 2019-02-22T10:23:55Z

Have you signed the contributor license agreement?
Have you followed the contributor guidelines?
If submitting code, have you built your formula locally prior to submission with gradle check?
If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
If submitting code, have you checked that your submission is for an OS that we support?
If you are submitting this code for a class then read our policy for that.

With this commit we remove all usages of the deprecated method `ExceptionsHelper#detailedMessage` in tests. We do not address production code here but rather in dedicated follow-up PRs to keep the individual changes manageable. Relates #19069

javanna · 2019-02-22T11:19:33Z

jenkins test this please

elasticmachine · 2019-02-22T11:19:56Z

Pinging @elastic/es-core-features

This fails on old_cluster but mixed_cluster and upgraded_cluster depend on watches set in old_cluster so that can't be muted on its own Relates: #33185

Relates to #39306

Relates to #39308

This test failed once in a very long time with the assertion that there is no document for the `non_existing_job` in the state index. I could not see how that is possible and I cannot reproduce. With this commit the failure message will reveal some examples of the left behind docs which might shed a light about what could go wrong.

Fixes a bug in DissectParserTests where the tests expected dissect keys to be unique but were not. Closes #39244

javanna · 2019-02-22T14:45:37Z

thanks for opening this PR @Eunovo ! The fix looks good to me and tests are green. Could you please add a test though, for instance to IndexNameExpressionResolverTests, that verifies that the error message is correct?

* [DATA-FRAME] add preview endpoint * adjusting preview tests and fixing parser * adjusing preview transport * remove unused import * adjusting test * Addressing PR comments * Fixing failing test and adjusting for pr comments * fixing integration test

…9311) The assertBusy() that waits the default 10 seconds for a datafeed to complete very occasionally times out on slow machines. This commit increases the timeout to 60 seconds. It will almost never actually take this long, but it's better to have a timeout that will prevent time being wasted looking at spurious test failures.

Create index with only 1 shard to ensure an expected request failure Closes #39218

Eunovo · 2019-02-22T18:25:35Z

@javanna to add something like

testConcreteIndiciesNoIndiciesErrorMessage()

to

https://github.com/Eunovo/elasticsearch/blob/master/server/src/test/java/org/elasticsearch/cluster/metadata/IndexNameExpressionResolverTests.java

1. Setting length for formatWarning String to avoid AbstractStringBuilder.ensureCapacityInternal calls 2. Adding extra check for parameter array length == 0 to avoid unnecessarily creating StringBuilder in LoggerMessageFormat.format Helps to narrow the performance gap in throughout for geonames benchmark (#37411) by 3%. For more details: #37530 (comment) Relates to #37530 Relates to #37411 Relates to #35754

This commit simplifies the use of transport mocking in the CCR retention lease integration tests. Instead of adding a send rule between nodes, we add a default send rule. This greatly simplifies the code here, and speeds the test up a little bit too.

The shard logged here is the leader shard but it should be the follower shard since this background retention lease renewal is happening on the follower side. This commit fixes that.

This test fails rarely but it is flaky in its current form. The problem here is that we lack a guarantee on the retention leases having been synced to all shard copies. We need to sleep long enough to ensure that that occurs, and then we can sample the retention leases, possibly sleep again (we usually will not have too since the first sleep will have been long enough to allow a sync and a renewal to happen, if one was going to happen), and the sample the retention leases for comparison. Closes #39331

This commit changes the sort order of shard stats that are collected in CCR retention lease integration tests. This change is done so that primaries appear first in sort order.

This commit adds some additional logging to a failing CCR retention lease test so that the nature of the failure can be completely understood before attempting to push a fix. Relates #39268

Finally! This commit should fix the issues with the CCR retention lease that has been plaguing build failures. The issue here is that we are trying to prevent the clear session requests from being executed until after we have been able to validate that retention leases are being renewed. However, we were only blocking the clear session requests but not blocking them when they are proxied through another node. This commit addresses that. Closes #39268

We tripped this assertion three times for the last two weeks. However, it only says "this IndexWriter is closed" without the actual cause. ``` [2019-02-14T11:46:31,144][ERROR][o.e.b.ElasticsearchUncaughtExceptionHandler] [node-1] fatal error in thread [elasticsearch[node-1][generic][T#2]], exiting java.lang.AssertionError: unexpected failure while replicating translog entry: org.apache.lucene.store.AlreadyClosedException: this IndexWriter is closed ``` This change replaces an assert with an AssertionError so that we will have the actual cause in the next build failures. Relates #38898

javanna · 2019-02-25T08:43:25Z

yes @Eunovo something along those lines sounds good.

javanna · 2019-03-07T10:47:35Z

hi @Eunovo , did you have a chance to work on the requested changes? I think that the git history contains non relevant changes, that may have been caused by rebasing. Would you mind fixing that either in this PR or by opening a new one that contains only your own commits? Thanks!

Eunovo · 2019-03-07T12:43:38Z

@javanna I'll open a new pull request

Eunovo and others added 2 commits February 21, 2019 13:35

Improved error message for absence indices closes #38964

619ddcd

javanna added the :Data Management/Indices APIs APIs to create and manage indices and templates label Feb 22, 2019

javanna added >enhancement v7.2.0 v8.0.0 labels Feb 22, 2019

jkakavas and others added 5 commits February 22, 2019 13:26

Mute rolling upgrade watcher CRUD tests (#39293)

d3bced2

This fails on old_cluster but mixed_cluster and upgraded_cluster depend on watches set in old_cluster so that can't be muted on its own Relates: #33185

Mute BasicWatcherTests.testConditionSearchWithIndexedTemplate (#39307)

31bfd91

Relates to #39306

Mute IndexFollowingIT.testDeleteLeaderIndex (#39309)

2b1c5a7

Relates to #39308

Fix DissectParserTests expecting unique keys (#39262)

1e7f28e

Fixes a bug in DissectParserTests where the tests expected dissect keys to be unique but were not. Closes #39244

benwtrent and others added 3 commits February 22, 2019 09:03

Fix the test failure in dense and sparse vectors (#39313)

256b1cb

Create index with only 1 shard to ensure an expected request failure Closes #39218

ebadyano and others added 8 commits February 22, 2019 15:05

Fix shard logged in background lease renewal

ab26a57

The shard logged here is the leader shard but it should be the follower shard since this background retention lease renewal is happening on the follower side. This commit fixes that.

Change sort order of shard stats in CCR test

14510a9

This commit changes the sort order of shard stats that are collected in CCR retention lease integration tests. This change is done so that primaries appear first in sort order.

Add test logging to CCR retention lease test

fee33d5

This commit adds some additional logging to a failing CCR retention lease test so that the nature of the failure can be completely understood before attempting to push a fix. Relates #39268

javanna self-assigned this Feb 25, 2019

Eunovo added 2 commits February 25, 2019 12:54

Improved error message for No Indices (closes #38964)

9d55105

removed old solution to #38964

14c2e76

Added tests for No Indices Error Message

c16d563

Eunovo closed this Mar 7, 2019

Eunovo mentioned this pull request Mar 7, 2019

Improve error message for absence of indices #39789

Merged

jakelandis added v8.0.0-alpha1 and removed v8.0.0 labels Jul 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improved error message for absence of indices closes #38964 #39296

Improved error message for absence of indices closes #38964 #39296

Uh oh!

Eunovo commented Feb 22, 2019

Uh oh!

javanna commented Feb 22, 2019

Uh oh!

elasticmachine commented Feb 22, 2019

Uh oh!

javanna commented Feb 22, 2019

Uh oh!

Eunovo commented Feb 22, 2019

Uh oh!

javanna commented Feb 25, 2019

Uh oh!

javanna commented Mar 7, 2019

Uh oh!

Eunovo commented Mar 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Improved error message for absence of indices closes #38964 #39296

Improved error message for absence of indices closes #38964 #39296

Uh oh!

Conversation

Eunovo commented Feb 22, 2019

Uh oh!

javanna commented Feb 22, 2019

Uh oh!

elasticmachine commented Feb 22, 2019

Uh oh!

javanna commented Feb 22, 2019

Uh oh!

Eunovo commented Feb 22, 2019

Uh oh!

javanna commented Feb 25, 2019

Uh oh!

javanna commented Mar 7, 2019

Uh oh!

Eunovo commented Mar 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants