Skip to content

Remove ExceptionsHelper#detailedMessage in tests #37921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 22, 2019
Merged

Remove ExceptionsHelper#detailedMessage in tests #37921

merged 4 commits into from
Feb 22, 2019

Conversation

@danielmitterdorfer
Copy link
Member

@danielmitterdorfer danielmitterdorfer commented Jan 28, 2019

With this commit we remove all usages of the deprecated method
ExceptionsHelper#detailedMessage in tests. We do not address
production code here but rather in dedicated follow-up PRs to keep the
individual changes manageable.

Relates #19069

@danielmitterdorfer
Remove ExceptionsHelper#detailedMessage in tests
b1e2085 
With this commit we remove all usages of the deprecated method
`ExceptionsHelper#detailedMessage` in tests. We do not address
production code here but rather in dedicated follow-up PRs to keep the
individual changes manageable.

Relates elastic#19069
@danielmitterdorfer danielmitterdorfer added >non-issue :Core/Infra/Core Core issues without another label v7.0.0 labels Jan 28, 2019
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 28, 2019

Pinging @elastic/es-core-infra

@danielmitterdorfer
Copy link
Member Author

danielmitterdorfer commented Jan 29, 2019

@elasticmachine run elasticsearch-ci/2

@danielmitterdorfer
Copy link
Member Author

danielmitterdorfer commented Jan 29, 2019

There was a network issue during the build:

08:35:22  [6.5.5]    > Could not resolve org.slf4j:slf4j-api:1.7.5.
08:35:22  [6.5.5]      Required by:
08:35:22  [6.5.5]          project :distribution:packages > com.netflix.nebula:gradle-ospackage-plugin:4.7.1 > org.redline-rpm:redline:1.2.6
08:35:22  [6.5.5]       > Could not resolve org.slf4j:slf4j-api:1.7.5.
08:35:22  [6.5.5]          > Could not get resource 'https://plugins.gradle.org/m2/org/slf4j/slf4j-api/1.7.5/slf4j-api-1.7.5.pom'.
08:35:22  [6.5.5]             > Could not HEAD 'https://plugins.gradle.org/m2/org/slf4j/slf4j-api/1.7.5/slf4j-api-1.7.5.pom'.
08:35:22  [6.5.5]                > Connection reset

@elasticmachine run elasticsearch-ci/2

@danielmitterdorfer
Copy link
Member Author

danielmitterdorfer commented Jan 29, 2019

@elasticmachine run elasticsearch-ci/default-distro

jdconrad
jdconrad approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasontedor jasontedor added v8.0.0 and removed v7.0.0 labels Feb 6, 2019
@danielmitterdorfer danielmitterdorfer merged commit ae8dee3 into elastic:master Feb 22, 2019
@danielmitterdorfer danielmitterdorfer deleted the remove-detailed-msg-test branch February 22, 2019 10:30
danielmitterdorfer added a commit to danielmitterdorfer/elasticsearch that referenced this pull request Feb 22, 2019
@danielmitterdorfer
Remove ExceptionsHelper#detailedMessage in tests (elastic#37921)
628c3f3 
With this commit we remove all usages of the deprecated method
`ExceptionsHelper#detailedMessage` in tests. We do not address
production code here but rather in dedicated follow-up PRs to keep the
individual changes manageable.

Relates elastic#19069
danielmitterdorfer added a commit that referenced this pull request Feb 22, 2019
@danielmitterdorfer
Remove ExceptionsHelper#detailedMessage in tests (#37921) (#39297)
9fea21a 
With this commit we remove all usages of the deprecated method
`ExceptionsHelper#detailedMessage` in tests. We do not address
production code here but rather in dedicated follow-up PRs to keep the
individual changes manageable.

Relates #19069
weizijun pushed a commit to weizijun/elasticsearch that referenced this pull request Feb 22, 2019
@danielmitterdorfer @weizijun
Remove ExceptionsHelper#detailedMessage in tests (elastic#37921)
24997da 
With this commit we remove all usages of the deprecated method
`ExceptionsHelper#detailedMessage` in tests. We do not address
production code here but rather in dedicated follow-up PRs to keep the
individual changes manageable.

Relates elastic#19069
weizijun pushed a commit to weizijun/elasticsearch that referenced this pull request Feb 22, 2019
@danielmitterdorfer @weizijun
Remove ExceptionsHelper#detailedMessage in tests (elastic#37921)
3b32d19 
With this commit we remove all usages of the deprecated method
`ExceptionsHelper#detailedMessage` in tests. We do not address
production code here but rather in dedicated follow-up PRs to keep the
individual changes manageable.

Relates elastic#19069
@DaveCTurner DaveCTurner mentioned this pull request Feb 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdconrad jdconrad jdconrad approved these changes

Assignees

No one assigned

Labels

:Core/Infra/Core Core issues without another label >non-issue v7.2.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danielmitterdorfer @elasticmachine @jdconrad @jakelandis @jasontedor