Skip to content

Conversation

@krisds
Copy link
Contributor

@krisds krisds commented Feb 1, 2019

As requested, I will split #38033 into separate PRs. Here is the fourth part.

This one resolves:

@jimczi jimczi added the :Analytics/SQL SQL querying label Feb 1, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@costin
Copy link
Member

costin commented Feb 1, 2019

Hi, thanks for raising the PR.
If I understand correctly this PR is about removing an unused variable, correct? I ask since the PR title is a bit misleading (not sure what "container" you refer to).

@krisds
Copy link
Contributor Author

krisds commented Feb 1, 2019

Correct. The container is nestedRefs, which is added to but never read.

PS. You can click the link in the description to see the original alert for more details.

@javanna javanna changed the title Container contents are never accessed (in QueryContainer) Remove unused variable in QueryContainer Feb 25, 2019
@javanna
Copy link
Member

javanna commented Feb 25, 2019

test this please

@javanna
Copy link
Member

javanna commented Feb 25, 2019

Same here @krisds if you could merge master in, that would be fantastic. Thank you.

@javanna
Copy link
Member

javanna commented Mar 18, 2019

retest this please

@javanna
Copy link
Member

javanna commented Mar 18, 2019

retest this please

@javanna
Copy link
Member

javanna commented Mar 20, 2019

run elasticsearch-ci/packaging-sample

@javanna javanna merged commit fe1e0af into elastic:master Mar 21, 2019
@javanna
Copy link
Member

javanna commented Mar 21, 2019

thanks @krisds !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants