Skip to content

Remove unused variable in QueryContainer #38152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Remove unused variable in QueryContainer #38152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2632f39
[Container contents are never accessed](https://lgtm.com/projects/g/e…
Jan 30, 2019
7b53eb1
Merge branch 'master' into lgtm-fix-4
javanna Mar 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ...ugin/sql/src/main/java/org/elasticsearch/xpack/sql/querydsl/container/QueryContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,16 +287,12 @@ private FieldExtraction topHitFieldRef(FieldAttribute fieldAttr) {
}

private Tuple<QueryContainer, FieldExtraction> nestedHitFieldRef(FieldAttribute attr) {
// Find the nested query for this field. If there isn't one then create it
List<FieldExtraction> nestedRefs = new ArrayList<>();

String name = aliasName(attr);
Query q = rewriteToContainNestedField(query, attr.source(),
attr.nestedParent().name(), name, attr.field().getDataType().format(), attr.field().isAggregatable());

SearchHitFieldRef nestedFieldRef = new SearchHitFieldRef(name, attr.field().getDataType(),
attr.field().isAggregatable(), attr.parent().name());
nestedRefs.add(nestedFieldRef);

return new Tuple<>(new QueryContainer(q, aggs, fields, aliases, pseudoFunctions, scalarFunctions, sort, limit, trackHits),
nestedFieldRef);
Expand Down