Skip to content

Conversation

@avshiav
Copy link
Contributor

@avshiav avshiav commented Feb 4, 2019

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

@alpar-t alpar-t added the :Docs label Feb 4, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this!

@javanna
Copy link
Member

javanna commented Feb 25, 2019

hi @avshiav could you please sign our CLA so we can merge your PR? Thanks again for opening it.

@avshiav
Copy link
Contributor Author

avshiav commented Feb 25, 2019 via email

@javanna
Copy link
Member

javanna commented Feb 25, 2019

@javanna
Copy link
Member

javanna commented Mar 20, 2019

jenkins test this please

@javanna javanna added :Search/Search Search-related issues that do not fall into other categories and removed :Docs labels Mar 20, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@javanna javanna added the >docs General docs changes label Mar 20, 2019
@javanna javanna merged commit 955ccf2 into elastic:master Mar 20, 2019
@javanna
Copy link
Member

javanna commented Mar 20, 2019

thanks @avshiav !

javanna pushed a commit to javanna/elasticsearch that referenced this pull request Mar 29, 2019
javanna pushed a commit that referenced this pull request Mar 29, 2019
@jakelandis jakelandis removed the v8.0.0 label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes :Search/Search Search-related issues that do not fall into other categories v7.2.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants