Remove discovery.type BWC layer from the EC2/Azure/GCE plugins
#25080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EC2 Test did not need to be modified like the other two.
Member
|
Can you explain what you did in the PR's title? It is super useful for those of us that use our email to decide which PRs to review. |
jmorph99
commented
Jun 6, 2017
Contributor
Author
|
Ok, I think it is updated.
…On Tue, Jun 6, 2017 at 2:57 PM, Nik Everett ***@***.***> wrote:
Can you explain what you did in the PR's title? It is super useful for
those of us that use our email to decide which PRs to review.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#25080 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJQUx9lYFUHoZVAaDH7ruKyErQ1IINl4ks5sBaEFgaJpZM4Nxwj1>
.
|
Member
|
@jmorph99 I think he means the issue title and the commit message. Right now it is "Issue #24543 Fix", which will be the first line of the commit message when this is merged. That title is not useful. Instead, I would expect something like "Remove discovery plugins legacy support for discovery.type". |
Contributor
Author
|
Thanks.
I apologize if I am slow to adapt.
…On Tue, Jun 6, 2017 at 8:16 PM, Ryan Ernst ***@***.***> wrote:
@jmorph99 <https://github.com/jmorph99> I think he means the issue title
and the commit message. Right now it is "Issue #24543
<#24543> Fix", which will
be the first line of the commit message when this is merged. That title is
not useful. Instead, I would expect something like "Remove discovery
plugins legacy support for discovery.type".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25080 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJQUx_nC8ifLu5OBFCmvTu5cJ9ss20B8ks5sBevFgaJpZM4Nxwj1>
.
|
bleskes
changed the title
discovery.type BWC layer from the EC2/Azure/GCE plugins
bleskes
suggested changes
Jun 8, 2017
Contributor
bleskes
left a comment
bleskes
left a comment
There was a problem hiding this comment.
Thx @jmorph99 for all the iterations. The code looks good! My only ask is that you add a note to the migration guide, here. I think something like adding a new section called GCE/Azure/EC2 discovery setting and note that discovery.type: ec2/azure/gce has been removed in favor of the discovery host provider variants.
jmorph99
added a commit
to jmorph99/elasticsearch
that referenced
this pull request
Jun 8, 2017
Contributor
Author
|
Ok - I think I did it successfully. |
jmorph99
added a commit
to jmorph99/elasticsearch
that referenced
this pull request
Jun 8, 2017
From pull request elastic#25080 (review)
Contributor
Author
|
Ever going to close this? |
Contributor
|
@jmorph99 I think you pushed your doc change to another branch of your repo and therefore they don't appear here. I suggest we just pull this PR as is and I can work on docs on as a follow up. Is that OK with you? Thanks for all the hard work. Git can be difficult. |
Contributor
Author
|
Sure - that will be fine.
…On Tue, Jun 13, 2017 at 2:59 AM, Boaz Leskes ***@***.***> wrote:
@jmorph99 <https://github.com/jmorph99> I think you pushed your doc
change to another branch of your repo and therefore they don't appear here.
I suggest we just pull this PR as is and I can work on docs on as a follow
up. Is that OK with you? Thanks for all the hard work. Git can be difficult.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25080 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJQUx4pxlve2DExw7HaRZ141ceSRgZYcks5sDjM1gaJpZM4Nxwj1>
.
|
bleskes
approved these changes
Jun 14, 2017
Contributor
|
Thx @jmorph99 ! |
bleskes
added a commit
that referenced
this pull request
Jun 14, 2017
bleskes
added a commit
that referenced
this pull request
Jun 14, 2017
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jun 14, 2017
* master: (27 commits) Refactor TransportShardBulkAction.executeUpdateRequest and add tests Make sure range queries are correctly profiled. (elastic#25108) Test: allow setting socket timeout for rest client (elastic#25221) Migration docs for elastic#25080 (elastic#25218) Remove `discovery.type` BWC layer from the EC2/Azure/GCE plugins elastic#25080 When stopping via systemd only kill the JVM, not its control group (elastic#25195) Remove PrefixAnalyzer, because it is no longer used. Internal: Remove Strings.cleanPath (elastic#25209) Docs: Add note about which secure settings are valid (elastic#25212) Indices.rollover/10_basic should refresh to make the doc visible in lucene stats Port support for commercial GeoIP2 databases from Logstash. (elastic#24889) [DOCS] Add ML node to node.asciidoc (elastic#24495) expose simple pattern tokenizers (elastic#25159) Test: add setting to change request timeout for rest client (elastic#25201) Fix secure repository-hdfs tests on JDK 9 Add target_field parameter to gsub, join, lowercase, sort, split, trim, uppercase (elastic#24133) Add Cross Cluster Search support for scroll searches (elastic#25094) Adapt skip version in rest-api-spec/test/indices.rollover/20_max_doc_condition.yml Rollover max docs should only count primaries (elastic#24977) Add remote cluster infrastructure to fetch discovery nodes. (elastic#25123) ...
jasontedor
added a commit
to glefloch/elasticsearch
that referenced
this pull request
Jun 15, 2017
* master: (44 commits) Upgrade icu4j for the ICU analysis plugin to 59.1 (elastic#25243) move assertBusy to use CheckException (elastic#25246) Use SPI in High Level Rest Client to load XContent parsers (elastic#25098) [TEST] test that low level REST client leaves path untouched (elastic#25193) Speed up PK lookups at index time. (elastic#19856) [Docs] Fix documentation for percentiles bucket aggregation (elastic#25229) Upgrade to lucene-7.0.0-snapshot-92b1783. (elastic#25222) Build: Add master flag for disabling bwc tests (elastic#25230) Scripting: Rename SearchScript.needsScores to needs_score (elastic#25235) Support script context stateful factory in Painless. (elastic#25233) FastVectorHighlighter should not cache the field query globally (elastic#25197) Remove QUERY_AND_FETCH BWC for pre-5.3.0 nodes (elastic#25223) Add more missing AggregationBuilder getters (elastic#25198) Extract the snapshot/restore full cluster restart tests from the translog full cluster restart tests (elastic#25204) Refactor TransportShardBulkAction.executeUpdateRequest and add tests Make sure range queries are correctly profiled. (elastic#25108) Test: allow setting socket timeout for rest client (elastic#25221) Migration docs for elastic#25080 (elastic#25218) Remove `discovery.type` BWC layer from the EC2/Azure/GCE plugins elastic#25080 When stopping via systemd only kill the JVM, not its control group (elastic#25195) ...
clintongormley
added
:Distributed Coordination/Discovery-Plugins
tlrx
pushed a commit
that referenced
this pull request
Mar 12, 2018
The docs state that `_gce_` is recommended but the code sample states that `_gce:hostname_` is recommended. This aligns the code sample with the documentation. Also replace `type` with `zen.hosts_provider` as discovery.type was removed in #25080.
tlrx
pushed a commit
that referenced
this pull request
Mar 12, 2018
The docs state that `_gce_` is recommended but the code sample states that `_gce:hostname_` is recommended. This aligns the code sample with the documentation. Also replace `type` with `zen.hosts_provider` as discovery.type was removed in #25080.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those plugins don't replace the discovery logic but rather only provide a custom unicast host provider for their respective platforms. in 5.1 we introduced the
discovery.zen.hosts_providersetting to better reflect it. This PR removes BWC code in those plugins as it is not needed anymoreFixes #24543