[discovery-gce] Align code examples and documentation #28876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs state that `_gce_` is recommended but the code sample states that `_gce:hostname_` is recommended. This aligns the code sample with the documentation. Also reordered the code sample to align with the documentation.
discovery.type was removed in #25080
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
shaneog
changed the title
rjernst
added
:Distributed Coordination/Discovery-Plugins
Member
|
/cc @elastic/es-distributed |
Contributor
|
@tlrx can you take a look? |
tlrx
approved these changes
Mar 12, 2018
Member
|
Thanks @shaneog ! |
tlrx
pushed a commit
that referenced
this pull request
Mar 12, 2018
The docs state that `_gce_` is recommended but the code sample states that `_gce:hostname_` is recommended. This aligns the code sample with the documentation. Also replace `type` with `zen.hosts_provider` as discovery.type was removed in #25080.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs state that
_gce_is recommended but the code sample statesthat
_gce:hostname_is recommended. This aligns the code sample withthe documentation.
Documentation: https://www.elastic.co/guide/en/elasticsearch/plugins/6.2/discovery-gce-network-host.html
Introduced in: #13612
I also replaced the use of
discovery.typein the code samples since this was removed in #25080.