[DOCS] Add ML node to node.asciidoc #24495
Conversation
docs/reference/modules/node.asciidoc
Outdated
There was a problem hiding this comment.
The coordinating node section below also needs to be updated to include ML nodes.
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
I left a note about distinguishing the case of X-Pack installed versus not installed.
docs/reference/modules/node.asciidoc
Outdated
There was a problem hiding this comment.
For a node that does not have X-Pack installed, these settings will cause node startup to fail. There needs to be a caveat to these settings so that users that are not using X-Pack do not copy/paste these into their settings and then get confused when startup fails. This comment applies throughout.
There was a problem hiding this comment.
I pushed a new commit that adds that information in multiple places.
docs/reference/modules/node.asciidoc
Outdated
There was a problem hiding this comment.
Do we want to link to the ML info here?
docs/reference/modules/node.asciidoc
Outdated
There was a problem hiding this comment.
Can we also reword the intro sentence? Instead of "Besides that, each node serves one or more
purpose" maybe "In addition, each node functions as one or more of the following node types:"
docs/reference/modules/node.asciidoc
Outdated
There was a problem hiding this comment.
This needs tweaked to include ML, too. Maybe say "By default, nodes are master-eligible data and ingest nodes. If X-Pack is installed, they are also machine learning nodes by default."
|
Thanks for all the feedback so far. I've implemented the suggested changes. |
|
I've made some changes, but I won't push them yet because they're dependent on #25164 |
|
I've added links from each node example to the "X-Pack node settings" per feedback from @eskibars, but they're propped so they only appear when we're doing the X-Pack-friendly (index-all.asciidoc) build. |
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
I left one more comment, then I'm good with it.
docs/reference/modules/node.asciidoc
Outdated
|
|
||
| ifdef::include-xpack[] | ||
| NOTE: These settings apply only when {xpack} is not installed. To create a | ||
| standalone master-eligible node when {xpack} is installed, see <<modules-node-xpack,{xpack} node settings>>. |
There was a problem hiding this comment.
I would say "dedicated" instead of "standalone" here, that's consistent with the other sections and consistent with what is already on the page regarding dedicated master-eligible nodes.
* [DOCS] Add ML node to node.asciidoc * [DOCS] Clarify ML node in node.asciidoc * [DOCS] Add X-Pack icon for admonition blocks * [DOCS] Formatting X-Pack blocks in node.asciidoc * [DOCS] Add xpack icon images to node.asciidoc * [DOCS] Add final xpack role attributes * [DOCS] Remove unnecssary xpackicon image * [DOCS] Add link to X-Pack node settings * [DOCS] Fix path to X-Pack repository * [DOCS] Add links to X-Pack node settings * [DOCS] Fixed text for links to X-Pack node settings * [DOCS] Change standalone node to dedicated node
* [DOCS] Add ML node to node.asciidoc * [DOCS] Clarify ML node in node.asciidoc * [DOCS] Add X-Pack icon for admonition blocks * [DOCS] Formatting X-Pack blocks in node.asciidoc * [DOCS] Add xpack icon images to node.asciidoc * [DOCS] Add final xpack role attributes * [DOCS] Remove unnecssary xpackicon image * [DOCS] Add link to X-Pack node settings * [DOCS] Fix path to X-Pack repository * [DOCS] Add links to X-Pack node settings * [DOCS] Fixed text for links to X-Pack node settings * [DOCS] Change standalone node to dedicated node
|
Verified that changes appear on external web. For example: |
* master: (27 commits) Refactor TransportShardBulkAction.executeUpdateRequest and add tests Make sure range queries are correctly profiled. (elastic#25108) Test: allow setting socket timeout for rest client (elastic#25221) Migration docs for elastic#25080 (elastic#25218) Remove `discovery.type` BWC layer from the EC2/Azure/GCE plugins elastic#25080 When stopping via systemd only kill the JVM, not its control group (elastic#25195) Remove PrefixAnalyzer, because it is no longer used. Internal: Remove Strings.cleanPath (elastic#25209) Docs: Add note about which secure settings are valid (elastic#25212) Indices.rollover/10_basic should refresh to make the doc visible in lucene stats Port support for commercial GeoIP2 databases from Logstash. (elastic#24889) [DOCS] Add ML node to node.asciidoc (elastic#24495) expose simple pattern tokenizers (elastic#25159) Test: add setting to change request timeout for rest client (elastic#25201) Fix secure repository-hdfs tests on JDK 9 Add target_field parameter to gsub, join, lowercase, sort, split, trim, uppercase (elastic#24133) Add Cross Cluster Search support for scroll searches (elastic#25094) Adapt skip version in rest-api-spec/test/indices.rollover/20_max_doc_condition.yml Rollover max docs should only count primaries (elastic#24977) Add remote cluster infrastructure to fetch discovery nodes. (elastic#25123) ...
5 participants
We need to update the node definitions for the new ML functionality