[DOC] Add X-Pack links to Elasticsearch Reference #25164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintongormley
approved these changes
Jun 12, 2017
Contributor
clintongormley
left a comment
clintongormley
left a comment
There was a problem hiding this comment.
LGTM (minor alignment issues)
docs/Versions.asciidoc
Outdated
| :plugins: https://www.elastic.co/guide/en/elasticsearch/plugins/{branch} | ||
| :javaclient: https://www.elastic.co/guide/en/elasticsearch/client/java-api/{branch} | ||
| :xpack: https://www.elastic.co/guide/en/x-pack/{branch} | ||
| :xpack-ref: https://www.elastic.co/guide/en/x-pack/{branch} |
Contributor
There was a problem hiding this comment.
Please line up the URL with the ones before and after. You don't use tabs by any chance, do you? We have a build check that will cause tabs to fail the build.
Contributor
Author
There was a problem hiding this comment.
Thanks, I'll avoid tabs in the future!
docs/Versions.asciidoc
Outdated
| :es: Elasticsearch | ||
| :kib: Kibana | ||
|
|
||
| :xes-repo-dir: {docdir}/../../elasticsearch-extra/x-pack-elasticsearch/docs/en |
Contributor
There was a problem hiding this comment.
Line the path up with the settings above
lcawl
added a commit
that referenced
this pull request
Jun 12, 2017
* [DOC] Add X-Pack links to Elasticsearch Reference * [DOCS] Address alignment of attributes in Versions.asciidoc
lcawl
added a commit
that referenced
this pull request
Jun 12, 2017
* [DOC] Add X-Pack links to Elasticsearch Reference * [DOCS] Address alignment of attributes in Versions.asciidoc
This was referenced Jun 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the infrastructure necessary to reference X-Pack content.
It uses a layout similar to what was worked out in the Kibana Reference for elastic/kibana#12062
It also adds some attribute definitions that are specific to X-Pack and changes the name of the attribute for the X-Pack Reference URL so that it does not cause confusion.