Remove `discovery.type` BWC layer from the EC2/Azure/GCE plugins

[bleskes]

Those plugins don't replace the discovery logic but rather only provide a custom unicast host provider for their respective platforms. in 5.1 we introduced the discovery.zen.hosts_provider setting to better reflect it. We should remove the BWC code in those plugins.

[Jefferysan]

Hi, I am new to the project and would like to take this as my first time contribution.

[bleskes]

@Jefferysan thank you for offering to contribute. Before starting I want to double check you have read our contributing guide. Since your github profile is empty I will go out on a limb and also ask you pay special attention to the section about contributing about a class assignment. Once you got everything working and have successfully run the tests, we can start iterating on the code. If you have any more questions, please feel free to ask.

PS this is marked as a blocker for 6.0. This means that there might be a point where we need it fixed. If you think you might not be able to drive this to a conclusion quickly (i.e., go through reviews and update your code accordingly until this is merged), maybe this one is not a good way to start.

[Jefferysan]

It had the low hanging fruit label attached to the issue so I thought it would be a good place to start. Is it maybe not the case?

[bleskes]

It had the low hanging fruit label attached to the issue so I thought it would be a good place to start. Is it maybe not the case?

My comments were about setting up a working environment so you'll need that for any PR. I think this one is OK to start with. I just wanted make sure it might become time sensitive at some point, so if you're not sure you will be able to finish it soon, you should probably pickup something else.

[jmorph99]

Hi, I have forked the source. This error looks simple, remove the values from those three files and any test files. I installed this on Ubuntu, I should probably document that! This took me a while. First I started with NetBeans ... So I have to use a new compiler now so I am trying IntelliJ. Anyways, my testClasses tests run fine but my integTest tests error, Do I need that to be working in order to do this project? If not I think I can follow your instructions to submit the fixes requested, I do not need a lot of hand-holding.

[rjernst]

my integTest tests error, Do I need that to be working in order to do this project

Yes, running gradle check needs to pass before any PR can be merged.

[jmorph99]

Yes that errors - I will execute it again with the "--stacktrace" option and output it to a text file. If you could take a quick look at it I think it might help. I will send it later, the tests take a long time.

…

On Sat, May 27, 2017 at 1:20 PM, Ryan Ernst ***@***.***> wrote: my integTest tests error, Do I need that to be working in order to do this project Yes, running gradle check needs to pass before any PR can be merged. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#24543 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJQUx7SEtbwjVdVAL8GLia2KAxsAsVSFks5r-FtIgaJpZM4NTvJ5> .

[jmorph99]

Also, I haven't done any modifications to the source code yet, I am simply trying to execute the tests after the Gradle install.

…

On Sat, May 27, 2017 at 2:04 PM, John Murphy ***@***.***> wrote: Yes that errors - I will execute it again with the "--stacktrace" option and output it to a text file. If you could take a quick look at it I think it might help. I will send it later, the tests take a long time. On Sat, May 27, 2017 at 1:20 PM, Ryan Ernst ***@***.***> wrote: > my integTest tests error, Do I need that to be working in order to do > this project > > Yes, running gradle check needs to pass before any PR can be merged. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#24543 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AJQUx7SEtbwjVdVAL8GLia2KAxsAsVSFks5r-FtIgaJpZM4NTvJ5> > . >

[jmorph99]

Ok, I eventually just reran it and for no apparent reason, it completed. *BUILD SUCCESSFULTotal time: 34 mins 52.896 secs* Onward I go, John

…

On Sat, May 27, 2017 at 2:07 PM, John Murphy ***@***.***> wrote: Also, I haven't done any modifications to the source code yet, I am simply trying to execute the tests after the Gradle install. On Sat, May 27, 2017 at 2:04 PM, John Murphy ***@***.***> wrote: > Yes that errors - I will execute it again with the "--stacktrace" option > and output it to a text file. If you could take a quick look at it I think > it might help. I will send it later, the tests take a long time. > > On Sat, May 27, 2017 at 1:20 PM, Ryan Ernst ***@***.***> > wrote: > >> my integTest tests error, Do I need that to be working in order to do >> this project >> >> Yes, running gradle check needs to pass before any PR can be merged. >> >> — >> You are receiving this because you commented. >> Reply to this email directly, view it on GitHub >> <#24543 (comment)>, >> or mute the thread >> <https://github.com/notifications/unsubscribe-auth/AJQUx7SEtbwjVdVAL8GLia2KAxsAsVSFks5r-FtIgaJpZM4NTvJ5> >> . >> > >