Remove CompactFramework references #9865
Conversation
|
One remains, in TypedTreeBasics.fs: (// Use TryDeref to guard against the platforms/times when certain F# language features aren't available,
// e.g. CompactFramework doesn't have support for quotations.
match x.TryDeref with
| ValueSome v1 -> match y.TryDeref with ValueSome v2 -> v1 === v2 | _ -> false
| _ -> match y.TryDeref with ValueNone -> true | _ -> false)Is this still needed or can this be replaced with |
|
|
|
@charlesroddie I think so, yes. |
charlesroddie
changed the title
|
Perhaps that branch was indeed needed for other circumstances :) |
|
This is failing some of the online builds and I can't reproduce the test failures locally. It's too minor to be worth a lot of effort to diagnose so I'll close and reopen later when the online builds change. |
* Reduce copying and allocations in lexing * Simplify and improve perf of eval * Dont create temporary array in discardInput since blit handles overlapping memory * Fix review comments and update a new method * rename methods * remove "new"
* Fixed generic union type instantiation on open type * Fixed record type instantiation. Added tests for pattern matching on union and records. * Consolidating fix * remove comment * Renamed field and updated comment * Minor updates
* cleanup old formatting code * cleanup old formatting code * cleanup old formatting code * cleanup old formatting code * cleanup old formatting code * cleanup old formatting code * cleanup old formatting code * cleanup old formatting code * cleanup old formatting code * Update sformat.fs
…lify generic code (RFC-1089) (dotnet#9549) * Merge from Re-enable-tests-for-operators * Add tests that cover the changes for fixing FS0670 * Un-inline `string` to allow used in generic overrides and types * Fix 3x C# default impl tests by removing dep. on FSharp.Core.dll * Implement new 'string' ideas from RFC-1089 * Some housekeeping, adding IFormattable to the list * Further optimizations for unsigned ints and (u)nativeint * Adding back 'inline' but not SRTP * Ignore NCrunch temp files and local user files * Fix string of enum-of-char * Fix tests in ExprTests.fs * Distinguish between FSharp.Core 4.5, 4.6 and 4.7 in tests in ExprTests.fs
|
Reopening so @abelbraaksma can take a look |
This reverts commit 9fb63c26d0f32a47556900f62ac87d8dcb810903.
abelbraaksma
force-pushed
the
RemoveCompactFrameworkReferences
branch
from
d7cc82c to
3b41412
Compare
|
@cartermp, it looks like CI is not "listening" anymore. Normally it starts running on each change, but nothing today: not after rebase, and not after committing a small irrelevant change. Oh wait, it is because the target is |
|
I'm continuing here, seems easier than trying to fix this: #9987. (edit: two hours later it magically started running anyway, weird stuff) |
|
Closed as done in #9987 |
10 participants
Remove CompactFramework references and supporting implementations, since CompactFramework is not supported.