Remove some unnecessary copying from lexer #9961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel-Svensson
commented
Aug 18, 2020
TIHan
reviewed
Aug 19, 2020
TIHan
reviewed
Aug 19, 2020
TIHan
reviewed
Aug 19, 2020
TIHan
approved these changes
Aug 19, 2020
Contributor
TIHan
left a comment
TIHan
left a comment
There was a problem hiding this comment.
This looks good, only a few minor nits.
I think the ReadOnlySpan use makes a lot of sense, but we will need to be careful as it doesn't mean the source won't change from underneath it.
cartermp
approved these changes
Aug 19, 2020
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Approved as well, subject to some nits. Thanks!
Contributor
|
nice! |
KevinRansom
approved these changes
Aug 20, 2020
* rename methods * remove "new"
Daniel-Svensson
commented
Aug 20, 2020
Contributor
Author
|
I've updated the style and added a small change to illex .fsl for integer parsing to use span |
Contributor
|
Thanks! |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Reduce copying and allocations in lexing * Simplify and improve perf of eval * Dont create temporary array in discardInput since blit handles overlapping memory * Fix review comments and update a new method * rename methods * remove "new"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some copying and allocations from the lexer code which was found when trying to learn how the lexing works.
I am new to F# so if there is some style issues please let me know.
If you prefer I can remove the
LexemeContainsandLexemeCharfrom lexbuf since the code can be rewritten tojust call ".Lexeme" and then index that one or do IndexOf on the span instead