cleanup old formatting code #9964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
Aug 20, 2020
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Changes seem fine, good to see some duplicate code removed.
KevinRansom
approved these changes
Aug 20, 2020
Contributor
Author
|
This is ready |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* cleanup old formatting code * cleanup old formatting code * cleanup old formatting code * cleanup old formatting code * cleanup old formatting code * cleanup old formatting code * cleanup old formatting code * cleanup old formatting code * cleanup old formatting code * Update sformat.fs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to make a small targetted improvement to the structured layout formatting and did a pass of cleanup over the relevant code before starting
Apply standard code cleanup to very old code
We had a duplicate implementation of "squashing" of layouts to fit a particular width - the one that's deleted is basically only used in debugging output in the compiler and we keep the one used in FSharp.Core.