Fix 'open type' on generic unions and records #9932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
reviewed
Aug 13, 2020
Contributor
Author
cartermp
approved these changes
Aug 15, 2020
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Changes seem straightforward, as do the tests. Are there any perf considerations for freshening a given record field reference? I don't have a good frame of reference for that, but I recall freshening being expensive for some things in a different PR and was curious.
Contributor
Author
|
As far as freshening and perf, we are not freshening any more than before so I'm not concerned. |
…sharp into fix-open-type-union-record
KevinRansom
approved these changes
Aug 21, 2020
dsyme
approved these changes
Aug 21, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Fixed generic union type instantiation on open type * Fixed record type instantiation. Added tests for pattern matching on union and records. * Consolidating fix * remove comment * Renamed field and updated comment * Minor updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9914
The best way to handle record labels and unions was adding a new field to name resolution to lookup the type instantiations based on
TyconRef.