Remove CompactFramework references #9987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9fb63c26d0f32a47556900f62ac87d8dcb810903.
Contributor
Author
|
Well, that proves it, the error that you (@charlesroddie) saw was an unfortunate fluke. This is exactly the same PR, the only difference being that it is taken off a more recent
Just added the ws cleanup. Other than that, @cartermp, this is ready (and thanks go to @charlesroddie for this, I didn't do a thing ;) ) |
vzarytovskii
approved these changes
Aug 22, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Remove CompactFramework-supporting implementations * Remove unneeded TryDeref and simplify OR logic * Revert "Remove unneeded TryDeref and simplify OR logic" This reverts commit 9fb63c26d0f32a47556900f62ac87d8dcb810903. * remove CompactFramework reference and simplify or logic take 2 * ws cleanup Co-authored-by: Charles Roddie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally from @charlesroddie here: #9865. Recreating because original was against
dotnet:masterand I don't seem to be able to change that.There was one tricky test failing and I'm hoping to fix that here. Original text:
"Remove CompactFramework references and supporting implementations, since CompactFramework is not supported."