Remove CompactFramework references (dotnet#9987)

* Remove CompactFramework-supporting implementations

* Remove unneeded TryDeref and simplify OR logic

* Revert "Remove unneeded TryDeref and simplify OR logic"

This reverts commit 9fb63c26d0f32a47556900f62ac87d8dcb810903.

* remove CompactFramework reference and simplify or logic take 2

* ws cleanup

Co-authored-by: Charles Roddie <[email protected]>

Author: 2 people

src/fsharp/FSharp.Core/event.fs

@@ -97,13 +97,10 @@ namespace Microsoft.FSharp.Control
                     // CreateDelegate creates a delegate that is fast to invoke.
                     invoker.Invoke(multicast, sender, args) |> ignore
 
-        member x.Publish = 
-            // Note, we implement each interface explicitly: this works around a bug in the CLR 
-            // implementation on CompactFramework 3.7, used on Windows Phone 7
+        member x.Publish =
             { new obj() with
                   member x.ToString() = "<published event>"
-              interface IEvent<'Delegate,'Args> 
-              interface IDelegateEvent<'Delegate> with 
+              interface IEvent<'Delegate,'Args> with 
                 member e.AddHandler(d) =
                     multicast <- System.Delegate.Combine(multicast, d) :?> 'Delegate 
                 member e.RemoveHandler(d) = 
@@ -126,13 +123,10 @@ namespace Microsoft.FSharp.Control
             match x.multicast with 
             | null -> ()
             | d -> d.Invoke(null,arg) |> ignore
-        member x.Publish = 
-            // Note, we implement each interface explicitly: this works around a bug in the CLR 
-            // implementation on CompactFramework 3.7, used on Windows Phone 7
+        member x.Publish =
             { new obj() with
                   member x.ToString() = "<published event>"
-              interface IEvent<'T> 
-              interface IDelegateEvent<Handler<'T>> with 
+              interface IEvent<'T> with 
                 member e.AddHandler(d) =
                     x.multicast <- (System.Delegate.Combine(x.multicast, d) :?> Handler<'T>)
                 member e.RemoveHandler(d) = 

src/fsharp/FSharp.Core/seqcore.fs

@@ -335,12 +335,9 @@ namespace Microsoft.FSharp.Core.CompilerServices
             (FinallyEnumerable(compensation, (fun () -> source)) :> seq<_>)
 
         let CreateEvent (addHandler : 'Delegate -> unit) (removeHandler : 'Delegate -> unit) (createHandler : (obj -> 'Args -> unit) -> 'Delegate ) :IEvent<'Delegate,'Args> =
-            // Note, we implement each interface explicitly: this works around a bug in the CLR
-            // implementation on CompactFramework 3.7, used on Windows Phone 7
             { new obj() with
                   member x.ToString() = "<published event>"
-              interface IEvent<'Delegate,'Args>
-              interface IDelegateEvent<'Delegate> with
+              interface IEvent<'Delegate,'Args> with
                  member x.AddHandler(h) = addHandler h
                  member x.RemoveHandler(h) = removeHandler h
               interface System.IObservable<'Args> with

src/fsharp/TypedTreeBasics.fs

@@ -412,17 +412,14 @@ let primUnionCaseRefEq compilingFslib fslibCcu (UnionCaseRef(tcr1, c1) as uc1) (
 ///
 /// Note this routine doesn't take type forwarding into account
 let primValRefEq compilingFslib fslibCcu (x: ValRef) (y: ValRef) =
-    x === y ||
-    if (x.IsResolved && y.IsResolved && x.ResolvedTarget === y.ResolvedTarget) ||
-       (x.IsLocalRef && y.IsLocalRef && valEq x.ResolvedTarget y.ResolvedTarget) then
-        true
-    else
-           (// Use TryDeref to guard against the platforms/times when certain F# language features aren't available,
-            // e.g. CompactFramework doesn't have support for quotations.
-            match x.TryDeref with
-            | ValueSome v1 -> match y.TryDeref with ValueSome v2 -> v1 === v2 | _ -> false
-            | _ -> match y.TryDeref with ValueNone -> true | _ -> false)
-        || (if compilingFslib then fslibValRefEq fslibCcu x y else false)
+    x === y
+    || (x.IsResolved && y.IsResolved && x.ResolvedTarget === y.ResolvedTarget)
+    || (x.IsLocalRef && y.IsLocalRef && valEq x.ResolvedTarget y.ResolvedTarget)
+    || // Use TryDeref to guard against the platforms/times when certain F# language features aren't available
+       match x.TryDeref with
+       | ValueSome v1 -> match y.TryDeref with ValueSome v2 -> v1 === v2 | ValueNone -> false
+       | ValueNone -> match y.TryDeref with ValueNone -> true | ValueSome _ -> false
+    || (compilingFslib && fslibValRefEq fslibCcu x y)
 
 //---------------------------------------------------------------------------
 // pubpath/cpath mess