-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[release/6.0] Define $(HelixTestConfigurationFilePath)
#42031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Define $(HelixTestConfigurationFilePath)
#42031
Conversation
- manual backport of #42029 - avoid problems caused by an undocumented dependency in the Helix SDK on the Arcade SDK - symptoms were a complete lack of retries in our Helix work items
|
Hi @dougbu. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
|
Test-only change for our next 6.0.x release |
|
Confirmed https://helixde107v0xdeko0k025g8.blob.core.windows.net/helix-job-3a5f4071-48bd-486e-92bf-b74ad23233b41678573a9384c24a3/ed290cfa-6c30-4423-b67a-908a19f2e514.zip?helixlogtype=result in correlation payload contains our test-configuration.json file. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@wtgodbe @BrennanConroy @Tratcher @adityamandaleeka could the test failures seen in this PR be due to a fix in I don't see an issue about either failing test. I didn't check the Helix queue thoroughly but think failures on OSX agents are quite common. Given I didn't see these failures in #42078 but they're happening in a number of open PRs targeting release/6.0, we could also be dealing w/ unexpected interactions between other PRs merged today (#41870, #41823, #41760). Other affected PRs targeting release/6.0 include #42085 (just a draft), #41993 (though new iteration may pass), #41992 (also retrying now), #41969 (yup, retrying now), and #41821 (failed a second attempt IIRC). That means, yes, this is an urgent issue. Specific failures:
|
|
The most interesting change that I think could be relevant is #37755 which makes it so we don't test against real time. This avoids any potential issues with straddling different days during the test run |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
$(HelixTestConfigurationFilePath)#42029