Skip to content

Conversation

@dougbu
Copy link
Contributor

@dougbu dougbu commented Jun 4, 2022

- manual backport of #42029
- avoid problems caused by an undocumented dependency in the Helix SDK on the Arcade SDK
- symptoms were a complete lack of retries in our Helix work items
@dougbu dougbu added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode labels Jun 4, 2022
@dougbu dougbu added this to the 6.0.x milestone Jun 4, 2022
@dougbu dougbu requested review from a team, ChadNedzlek, HaoK and wtgodbe June 4, 2022 01:02
@ghost
Copy link

ghost commented Jun 4, 2022

Hi @dougbu. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@ghost
Copy link

ghost commented Jun 4, 2022

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@dougbu
Copy link
Contributor Author

dougbu commented Jun 4, 2022

Test-only change for our next 6.0.x release

@dougbu dougbu enabled auto-merge (squash) June 4, 2022 01:03
@dougbu dougbu disabled auto-merge June 4, 2022 01:04
@dougbu
Copy link
Contributor Author

dougbu commented Jun 4, 2022

@dougbu
Copy link
Contributor Author

dougbu commented Jun 7, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dougbu
Copy link
Contributor Author

dougbu commented Jun 8, 2022

@wtgodbe @BrennanConroy @Tratcher @adityamandaleeka could the test failures seen in this PR be due to a fix in FileLoggerProcessorTests (or perhaps something under that class) that hasn't been backported from 'main'❔ I'm wondering about #41375 for example. But the files are pretty difficult to compare, even ignoring spacing.

I don't see an issue about either failing test. I didn't check the Helix queue thoroughly but think failures on OSX agents are quite common.

Given I didn't see these failures in #42078 but they're happening in a number of open PRs targeting release/6.0, we could also be dealing w/ unexpected interactions between other PRs merged today (#41870, #41823, #41760).

Other affected PRs targeting release/6.0 include #42085 (just a draft), #41993 (though new iteration may pass), #41992 (also retrying now), #41969 (yup, retrying now), and #41821 (failed a second attempt IIRC). That means, yes, this is an urgent issue.


Specific failures:

  • Microsoft.AspNetCore.HttpLogging.FileLoggerProcessorTests.RollsTextFilesWhenFirstLogOfDayIsMissing
    System.TimeoutException : The operation has timed out.
    Stack trace ``` text at Microsoft.AspNetCore.Testing.TaskExtensions.TimeoutAfter(Task task, TimeSpan timeout, String filePath, Int32 lineNumber) in /_/src/Shared/TaskExtensions.cs:line 125 at Microsoft.AspNetCore.HttpLogging.FileLoggerProcessorTests.RollsTextFilesWhenFirstLogOfDayIsMissing() in /_/src/Middleware/HttpLogging/test/FileLoggerProcessorTests.cs:line 425 at Microsoft.AspNetCore.HttpLogging.FileLoggerProcessorTests.RollsTextFilesWhenFirstLogOfDayIsMissing() in /_/src/Middleware/HttpLogging/test/FileLoggerProcessorTests.cs:line 425 ```
  • Microsoft.AspNetCore.HttpLogging.FileLoggerProcessorTests.StopsLoggingAfter10000Files
    System.TimeoutException : The operation has timed out.
    Stack trace ``` text at Microsoft.AspNetCore.Testing.TaskExtensions.TimeoutAfter(Task task, TimeSpan timeout, String filePath, Int32 lineNumber) in /_/src/Shared/TaskExtensions.cs:line 125 at Microsoft.AspNetCore.HttpLogging.FileLoggerProcessorTests.StopsLoggingAfter10000Files() in /_/src/Middleware/HttpLogging/test/FileLoggerProcessorTests.cs:line 220 at Microsoft.AspNetCore.HttpLogging.FileLoggerProcessorTests.StopsLoggingAfter10000Files() in /_/src/Middleware/HttpLogging/test/FileLoggerProcessorTests.cs:line 241 ```

@BrennanConroy
Copy link
Member

The most interesting change that I think could be relevant is #37755 which makes it so we don't test against real time. This avoids any potential issues with straddling different days during the test run

@wtgodbe
Copy link
Member

wtgodbe commented Jun 9, 2022

#42115

@wtgodbe
Copy link
Member

wtgodbe commented Jun 9, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dougbu dougbu merged commit ecdeda7 into dotnet:release/6.0 Jun 9, 2022
@dougbu dougbu deleted the dougbu/include.test-configuration.6.0 branch June 9, 2022 22:58
@dougbu dougbu modified the milestones: 6.0.x, 6.0.7 Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants