Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 1, 2022

Bumps src/submodules/googletest from 8ded48c to 548b13d.

Commits
  • 548b13d Fix internal files
  • e649993 gmock-spec-builders: remove the name for an unused parameter.
  • 9d21db9 gmock-spec-builders: add support for non-moveable types.
  • 6cd3823 Clarify that this-> is needed to access members of type-parameterized tests.
  • 2835677 gmock-actions: properly support non-moveable results in is_callable_r.
  • 56246cd gmock-spec-builders: move a method to the header.
  • cf942a5 Update GoogleTest documentation's spelling of "GoogleTest".
  • 7041051 Clarify the pitfalls of EXPECT_THAT and highlight it's best practices
  • 8d51dc5 gmock-internal-utils.cc: Avoid implicit conversion from int to char
  • 5126f71 gmock-actions: add support for move-only values to Return.
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [src/submodules/googletest](https://github.com/google/googletest) from `8ded48c` to `548b13d`.
- [Release notes](https://github.com/google/googletest/releases)
- [Commits](google/googletest@8ded48c...548b13d)

---
updated-dependencies:
- dependency-name: src/submodules/googletest
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested review from a team, dougbu and wtgodbe as code owners June 1, 2022 12:23
@dependabot dependabot bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 1, 2022
@ghost ghost added this to the 6.0.x milestone Jun 1, 2022
@ghost
Copy link

ghost commented Jun 1, 2022

Hi @dependabot[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@ghost
Copy link

ghost commented Jun 1, 2022

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@dougbu
Copy link
Contributor

dougbu commented Jun 1, 2022

Shoot, the Development versus Production issue is now showing up in release/6.0 as well 😦. We need to figure this out❕

/cc @MackinnonBuck @javiercn (as build ops people today and tomorrow) and @dotnet/aspnet-build

Note I'm retrying failed jobs in hopes the problem doesn't recur in later attempts. Look at the first attempt if you want to see what I'm seeing.

@dougbu
Copy link
Contributor

dougbu commented Jun 1, 2022

/fyi

Microsoft.AspNetCore.Mvc.FunctionalTests.SimpleWithWebApplicationBuilderTests.DefaultEnvironment_Is_Development
Assert.Equal() Failure
          ↓ (pos 0)
Expected: Development
Actual:   Production
          ↑ (pos 0)

Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to get ready (if latest validation attempt succeeds) for when branches open

@dougbu
Copy link
Contributor

dougbu commented Jun 7, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Jun 8, 2022
@wtgodbe wtgodbe merged commit 5ad4faf into release/6.0 Jun 9, 2022
@wtgodbe wtgodbe deleted the dependabot/submodules/release/6.0/src/submodules/googletest-548b13d branch June 9, 2022 20:41
@wtgodbe wtgodbe modified the milestones: 6.0.x, 6.0.7 Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants