Handle spaces after request line #41823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hi @Tratcher. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
Tratcher
added
the
Servicing-consider
|
Hi @Tratcher. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
halter73
reviewed
May 25, 2022
halter73
reviewed
May 25, 2022
halter73
approved these changes
May 25, 2022
Tratcher
force-pushed
the
tratcher/release/6.0/hspace
branch
from
e1ee716 to
4f7d721
Compare
davidfowl
reviewed
May 26, 2022
| if (_allowSpaceAfterRequestLine) | ||
| { | ||
| // Skip a space after the request line | ||
| if (reader.TryPeek(out byte s) && s == ByteSpace) |
Member
Author
There was a problem hiding this comment.
Yes, from the reports we think that's all we need.
Member
|
This was approved over email. |
Pilchie
added
Servicing-approved
adityamandaleeka
approved these changes
May 27, 2022
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle spaces after request line
Handle malformed requests with a space between the request line and the first header
Description
A partner team reported compat issues with a client that is sending a space between the HTTP/1.1 request line and the first header. Kestrel (correctly) rejects this request as invalid. IIS allows this. The client will eventually be fixed, but they've requested a 6.0 patch to unblock them for the next few months. We do not plan to port this change to main/7.0.
Fixes #41824
Customer Impact
Preventing customer adoption of Kestrel due to client comapt issues.
Regression?
Risk
This is an opt in adjustment to the parser.
Verification
Packaging changes reviewed?