Skip to content

[release/6.0] Make tests for FileLoggerProcessor system time independent #42115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 9, 2022
Merged

[release/6.0] Make tests for FileLoggerProcessor system time independent #42115

merged 4 commits into from
Jun 9, 2022
+156 −86

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jun 9, 2022

#37755

Seeing if this fixes the test failures we've seen in release/6.0

@wtgodbe wtgodbe requested a review from dougbu June 9, 2022 17:03
@ghost ghost added the area-runtime label Jun 9, 2022
@ghost ghost added this to the 6.0.x milestone Jun 9, 2022
@ghost
Copy link

ghost commented Jun 9, 2022

Hi @wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@wtgodbe wtgodbe mentioned this pull request Jun 9, 2022
Merged
@dougbu
Copy link
Contributor

dougbu commented Jun 9, 2022

Thanks @wtgodbe

Now, 🤞

@dougbu
Copy link
Contributor

dougbu commented Jun 9, 2022

I'm not actually optimistic because the OSX job in https://dev.azure.com/dnceng/public/_build/results?buildId=1812452&view=ms.vss-test-web.build-test-results-tab&runId=48177336&resultId=120023&paneView=attachments (which was validating #42031) kicked off at 2022-06-08T01:13:24.4650729Z, not just before midnight.

@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 9, 2022

These 2 tests were added in #41492, which was a backport of #41375 that had to be fixed manually to account for the fact that #37755 wasn't in 6.0. Hopefully backporting that & making those 2 tests the exact same as in main will catch whatever made those 2 fail in the first place

@dougbu
Copy link
Contributor

dougbu commented Jun 9, 2022

Got it, ta

dougbu
dougbu reviewed Jun 9, 2022
View reviewed changes
@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 9, 2022

No test failures here, let's see if this fixes other PRs

@wtgodbe wtgodbe merged commit f9e44c9 into dotnet:release/6.0 Jun 9, 2022
@wtgodbe wtgodbe deleted the wtgodbe/BackportLog branch June 9, 2022 20:54
@wtgodbe wtgodbe modified the milestones: 6.0.x, 6.0.7 Jun 9, 2022
@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Jun 9, 2022
@wtgodbe wtgodbe mentioned this pull request Jun 9, 2022
Closed
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tratcher Tratcher Awaiting requested review from Tratcher

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Milestone

6.0.7

Development

Successfully merging this pull request may close these issues.

4 participants

@wtgodbe @dougbu @amcasey @benedikt257