Determine next log file number from directory on first run #41492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-runtime
community-contribution
|
Hi @dustinsoftware. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
dustinsoftware
force-pushed
the
pr-41375-backport
branch
from
37287de to
58e561a
Compare
adityamandaleeka
added
the
Servicing-consider
|
Hi @dustinsoftware. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
rbhanda
added
Servicing-approved
Contributor
|
/ping reviewers (so that it makes it into 6.0.6) |
wtgodbe
approved these changes
May 5, 2022
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Determine next log file number from directory on first run
Backport of #41375 to 6.0
Restores file logging behavior after the app restarts multiple times in a single day.
Description
Fixes #41326
Customer Impact
Without this patch, an app that restarts multiple times per day (due to CI or app crashes) will stop logging w3c logs until the next day.
Regression?
Risk
This code is called on every web request, but the logic to determine the first filename only runs once per app start, and has guards when parsing the highest log number from the existing files on disk.
Verification
Packaging changes reviewed?