Skip to content

Conversation

@MackinnonBuck
Copy link
Member

Fix line endings for SPA proxy script on MacOS

Fixes an issue where the SPA proxy stop script would fail on MacOS.

Description

The generated script that kills old SPA proxy child processes was failing on MacOS due to the script having CRLF line endings. This PR solves the problem by applying line endings for the current platform.

Fixes #39261

Customer Impact

If child processes are not killed properly, running the project multiple times may fail, forcing the customer to manually kill orphaned processes.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

The change is small, and it uses string.ReplaceLineEndings(), which is a reliable method for replacing the line endings of a string with those appropriate for the current platform.

Verification

  • Manual (required)
  • Automated

Before:
image

After:
image

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@ghost ghost added the area-runtime label May 24, 2022
@ghost ghost added this to the 6.0.x milestone May 24, 2022
@ghost
Copy link

ghost commented May 24, 2022

Hi @MackinnonBuck. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@MackinnonBuck MackinnonBuck added the Servicing-consider Shiproom approval is required for the issue label May 24, 2022
@ghost
Copy link

ghost commented May 24, 2022

Hi @MackinnonBuck. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@MackinnonBuck MackinnonBuck requested a review from javiercn May 24, 2022 21:08
@MackinnonBuck MackinnonBuck added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels May 24, 2022
@mkArtakMSFT mkArtakMSFT modified the milestones: 6.0.x, 6.0.6 May 25, 2022
@mkArtakMSFT
Copy link
Contributor

@MackinnonBuck please wait until the branches open for July update before merging this. @wtgodbe can you please let @MackinnonBuck know when this is ready to merge? Thanks!

@MackinnonBuck MackinnonBuck added the * NO MERGE * Do not merge this PR as long as this label is present. label May 25, 2022
@MackinnonBuck
Copy link
Member Author

@wtgodbe Is this safe to merge now?

@wtgodbe
Copy link
Member

wtgodbe commented Jun 1, 2022

Branches will open after we do branding next Tuesday, 6/7. You can generally find the schedule for when branches are open here: https://dev.azure.com/devdiv/DevDiv/_wiki/wikis/DevDiv.wiki/8694/NET-Servicing-Schedule

@dougbu
Copy link
Contributor

dougbu commented Jun 7, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dougbu
Copy link
Contributor

dougbu commented Jun 7, 2022

Our release/6.0 branch is open now but you won't be able to merge @MackinnonBuck -- even if build works fine. Please remind me if I don't come back to this tomorrow or Thursday.

@dougbu
Copy link
Contributor

dougbu commented Jun 7, 2022

Also please remove the *NO MERGE* label if it's only here because the branch was closed

@dougbu
Copy link
Contributor

dougbu commented Jun 7, 2022

Oops. Also please get a team member to approve

@mkArtakMSFT mkArtakMSFT removed the * NO MERGE * Do not merge this PR as long as this label is present. label Jun 9, 2022
@wtgodbe wtgodbe merged commit 82ee208 into release/6.0 Jun 9, 2022
@wtgodbe wtgodbe deleted the mbuck/backport-fix-spa-proxy-bash-script branch June 9, 2022 20:56
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants