-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[release/6.0] Fix line endings for SPA proxy script on MacOS #41821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @MackinnonBuck. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
|
Hi @MackinnonBuck. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
|
@MackinnonBuck please wait until the branches open for July update before merging this. @wtgodbe can you please let @MackinnonBuck know when this is ready to merge? Thanks! |
|
@wtgodbe Is this safe to merge now? |
|
Branches will open after we do branding next Tuesday, 6/7. You can generally find the schedule for when branches are open here: https://dev.azure.com/devdiv/DevDiv/_wiki/wikis/DevDiv.wiki/8694/NET-Servicing-Schedule |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Our release/6.0 branch is open now but you won't be able to merge @MackinnonBuck -- even if build works fine. Please remind me if I don't come back to this tomorrow or Thursday. |
|
Also please remove the |
|
Oops. Also please get a team member to approve |
Fix line endings for SPA proxy script on MacOS
Fixes an issue where the SPA proxy stop script would fail on MacOS.
Description
The generated script that kills old SPA proxy child processes was failing on MacOS due to the script having CRLF line endings. This PR solves the problem by applying line endings for the current platform.
Fixes #39261
Customer Impact
If child processes are not killed properly, running the project multiple times may fail, forcing the customer to manually kill orphaned processes.
Regression?
Risk
The change is small, and it uses
string.ReplaceLineEndings(), which is a reliable method for replacing the line endings of a string with those appropriate for the current platform.Verification
Before:

After:

Packaging changes reviewed?