Skip to content

[release/6.0] Fix line endings for SPA proxy script on MacOS #41821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2022
Merged

[release/6.0] Fix line endings for SPA proxy script on MacOS #41821

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a54b70e
Fix line endings for SPA proxy script on MacOS
MackinnonBuck May 23, 2022
1f65847
Update SpaProxyLaunchManager.cs
MackinnonBuck May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Middleware/Spa/SpaProxy/src/SpaProxyLaunchManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ private void LaunchStopScriptMacOS(int spaProcessId)
{
var fileName = Guid.NewGuid().ToString("N") + ".sh";
var scriptPath = Path.Combine(AppContext.BaseDirectory, fileName);
var stopScript = @$"function list_child_processes(){{
var stopScript = @$"function list_child_processes () {{
local ppid=$1;
local current_children=$(pgrep -P $ppid);
local local_child;
Expand Down Expand Up @@ -282,7 +282,7 @@ private void LaunchStopScriptMacOS(int spaProcessId)
done;
rm {scriptPath};
";
File.WriteAllText(scriptPath, stopScript);
File.WriteAllText(scriptPath, stopScript.ReplaceLineEndings());

var stopScriptInfo = new ProcessStartInfo("/bin/bash", scriptPath)
{
Expand Down