Skip to content

Make CertificateConfig linker friendly #25493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

Make CertificateConfig linker friendly #25493

wants to merge 9 commits into from

Conversation

@benaadams
Copy link
Member

@benaadams benaadams commented Sep 1, 2020

#25485 targeting 5.0

Currently can't use Certificates from config files if you link ASP.NET as all the setters for the config section are removed.

This directly references the properties rather than nebulously reflecting them via object so the linker will preserve them as they are directly used.

Resolves #25482

jkotalik and others added 9 commits August 31, 2020 15:21
@jkotalik
Avoid build race between x64 and x86 (dotnet#25465)
071a539
@halter73
Add async ServerOptionsSelectionCallback UseHttps overload (dotnet#25390
04f23ec 
)
@dougbu
Do not use $(AppRuntimeVersion) or NETCore version for shared Fx in…
48c1261 
… Helix runs (dotnet#25477)

- remove hard-coded `$(AppRuntimeVersion)` property entirely
  - use `$(SharedFxVersion)` instead

nits:
- make `RunTests` help more clear about how `--runtime` option is used
- remove unused `--sdk` option on `RunTests` command line
- add Microsoft.AspNetCore.App.Ref package to Helix content later, ensuring it exists
@dougbu
Mark some projects as non-packable or non-shippable (dotnet#25468)
7579b30 
- used `$(IsTestAssetProject)` in src/Razor/test; slightly more correct
  - we don't have a special category for test infrastructure projects
@dotnet-maestro
[release/5.0] Update dependencies from dotnet/arcade dotnet/runtime d…
a7a2800 
…otnet/efcore (dotnet#25469)

[release/5.0] Update dependencies from dotnet/arcade dotnet/runtime dotnet/efcore
- Updates:
  - Microsoft.EntityFrameworkCore.Tools: from 5.0.0-rc.1.20431.2 to 5.0.0-rc.1.20431.9
  - Microsoft.EntityFrameworkCore.SqlServer: from 5.0.0-rc.1.20431.2 to 5.0.0-rc.1.20431.9
  - dotnet-ef: from 5.0.0-rc.1.20431.2 to 5.0.0-rc.1.20431.9
  - Microsoft.EntityFrameworkCore: from 5.0.0-rc.1.20431.2 to 5.0.0-rc.1.20431.9
  - Microsoft.EntityFrameworkCore.Design: from 5.0.0-rc.1.20431.2 to 5.0.0-rc.1.20431.9
  - Microsoft.EntityFrameworkCore.Relational: from 5.0.0-rc.1.20431.2 to 5.0.0-rc.1.20431.9
  - Microsoft.EntityFrameworkCore.Sqlite: from 5.0.0-rc.1.20431.2 to 5.0.0-rc.1.20431.9
  - Microsoft.EntityFrameworkCore.InMemory: from 5.0.0-rc.1.20431.2 to 5.0.0-rc.1.20431.9

- Updates:
  - System.ComponentModel.Annotations: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Diagnostics.DiagnosticSource: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Diagnostics.EventLog: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.DirectoryServices.Protocols: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Logging.Abstractions: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Logging.Configuration: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Logging.Console: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Logging.Debug: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Logging.EventLog: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Logging.EventSource: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Logging.TraceSource: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Options: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Options.ConfigurationExtensions: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Options.DataAnnotations: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Primitives: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Logging: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Internal.Transport: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Http: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Hosting.Abstractions: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Caching.Abstractions: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Caching.Memory: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Configuration: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Configuration.Abstractions: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Configuration.Binder: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Configuration.CommandLine: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Configuration.EnvironmentVariables: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Configuration.FileExtensions: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Configuration.Ini: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Configuration.UserSecrets: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Configuration.Xml: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.DependencyInjection: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.DependencyInjection.Abstractions: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.DependencyModel: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.FileProviders.Abstractions: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.FileProviders.Composite: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.FileProviders.Physical: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.FileSystemGlobbing: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.HostFactoryResolver.Sources: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Hosting: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Extensions.Configuration.Json: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.NETCore.App.Runtime.win-x64: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.NETCore.BrowserDebugHost.Transport: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.NETCore.Platforms: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Win32.Registry: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.Win32.SystemEvents: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.NETCore.App.Internal: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - Microsoft.NETCore.App.Ref: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Drawing.Common: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Text.Json: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Threading.Channels: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Windows.Extensions: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Text.Encodings.Web: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.ServiceProcess.ServiceController: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.IO.Pipelines: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Net.Http.Json: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Net.Http.WinHttpHandler: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Net.WebSockets.WebSocketProtocol: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Reflection.Metadata: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Resources.Extensions: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Runtime.CompilerServices.Unsafe: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Security.AccessControl: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Security.Cryptography.Cng: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Security.Cryptography.Pkcs: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Security.Cryptography.Xml: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Security.Permissions: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14
  - System.Security.Principal.Windows: from 5.0.0-rc.1.20431.5 to 5.0.0-rc.1.20431.14

- Updates:
  - Microsoft.DotNet.Build.Tasks.Installers: from 5.0.0-beta.20427.5 to 5.0.0-beta.20431.1
  - Microsoft.DotNet.Helix.Sdk: from 5.0.0-beta.20427.5 to 5.0.0-beta.20431.1
  - Microsoft.DotNet.Arcade.Sdk: from 5.0.0-beta.20427.5 to 5.0.0-beta.20431.1

 - Merge branch 'release/5.0' into darc-release/5.0-46fc5024-d7ad-477c-9089-31f91f2fb7a6
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20200…
748686f 
…831.10 (dotnet#25488)

[release/5.0] Update dependencies from dotnet/efcore
- Updates:
  - Microsoft.EntityFrameworkCore.Tools: from 5.0.0-rc.1.20431.9 to 5.0.0-rc.1.20431.10
  - Microsoft.EntityFrameworkCore.SqlServer: from 5.0.0-rc.1.20431.9 to 5.0.0-rc.1.20431.10
  - dotnet-ef: from 5.0.0-rc.1.20431.9 to 5.0.0-rc.1.20431.10
  - Microsoft.EntityFrameworkCore: from 5.0.0-rc.1.20431.9 to 5.0.0-rc.1.20431.10
  - Microsoft.EntityFrameworkCore.Design: from 5.0.0-rc.1.20431.9 to 5.0.0-rc.1.20431.10
  - Microsoft.EntityFrameworkCore.Relational: from 5.0.0-rc.1.20431.9 to 5.0.0-rc.1.20431.10
  - Microsoft.EntityFrameworkCore.Sqlite: from 5.0.0-rc.1.20431.9 to 5.0.0-rc.1.20431.10
  - Microsoft.EntityFrameworkCore.InMemory: from 5.0.0-rc.1.20431.9 to 5.0.0-rc.1.20431.10
Fix Unhandled DBErrors in ComponentsWebAssembly and Spa templates (do…
222dd67 
…tnet#25466)

* Add workaround for EF issue dotnet/efcore#22341
@Pilchie
Api baselines (dotnet#25386)
95c526f 
* Enable Public API analyzer for some projects

* Analyzers
* Antiforgery
* Azure (except AzureAD.UI and AzureADB2C.UI due to issues with Razor compiler)
* Configuration.KeyPerFile
* DataProtection
* DefaultBuilder
* Features/JsonPatch
* FileProviders
* HealthChecks
* Hosting
@benaadams
Make CertificateConfig linker friendly
f9729df
@ghost ghost added the area-servers label Sep 1, 2020
@benaadams benaadams mentioned this pull request Sep 1, 2020
Closed
@Tratcher Tratcher self-assigned this Sep 1, 2020
@Tratcher
Copy link
Member

Tratcher commented Sep 1, 2020

Sorry, I timed that badly. release/5.0 locked down today for rc1. However, you can rebase onto release/5.0-rc2.

@Tratcher Tratcher added this to the 5.0.0-rc2 milestone Sep 1, 2020
@benaadams
Copy link
Member Author

benaadams commented Sep 1, 2020

I think you are secretly testing my retargeting skills 😅

@Tratcher
Copy link
Member

Tratcher commented Sep 1, 2020

I think you are secretly testing my retargeting skills 😅

A challenge worth of any master dev.

@Tratcher
Copy link
Member

Tratcher commented Sep 1, 2020

@Pilchie rc2 merge please.

@Tratcher
Copy link
Member

Tratcher commented Sep 1, 2020

Wait... wrong branch.

@benaadams benaadams changed the base branch from release/5.0 to release/5.0-rc2 September 1, 2020 22:04
@benaadams
Copy link
Member Author

benaadams commented Sep 1, 2020

Bleh

@benaadams benaadams closed this Sep 1, 2020
@benaadams
Copy link
Member Author

benaadams commented Sep 1, 2020

New PR, #25515

Using the GitHub UI to retarget wasn't a good idea 🤣

@benaadams benaadams deleted the Make-CertificateConfig-linker-friendly branch September 2, 2020 01:56
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tratcher Tratcher Tratcher approved these changes

@halter73 halter73 Awaiting requested review from halter73

@jkotalik jkotalik Awaiting requested review from jkotalik

@dougbu dougbu Awaiting requested review from dougbu

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

Assignees

@Tratcher Tratcher

Labels

area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

5.0.0-rc2

Development

Successfully merging this pull request may close these issues.

7 participants

@benaadams @Tratcher @amcasey @jkotalik @halter73 @dougbu @Pilchie