Skip to content

Fix Unhandled DBErrors in ComponentsWebAssembly and Spa templates #25466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2020
Merged

Fix Unhandled DBErrors in ComponentsWebAssembly and Spa templates #25466

merged 3 commits into from
Sep 1, 2020

Conversation

@JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo commented Aug 31, 2020

Fixes #25348. The original change had a bug where calls to AddDatabaseDeveloperPageExceptionFilter were nested in a #else clause by mistake.

I'll verify these changes manually.

@JunTaoLuo JunTaoLuo requested a review from a team as a code owner August 31, 2020 19:59
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Aug 31, 2020
@JunTaoLuo JunTaoLuo added the tell-mode Indicates a PR which is being merged during tell-mode label Aug 31, 2020
@JunTaoLuo JunTaoLuo requested a review from Tratcher as a code owner September 1, 2020 00:05
@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Sep 1, 2020

During verification I found another issue that caused a null ref: dotnet/efcore#22341. Turns out @javiercn also saw the same problem during his attempt to resolve the issue. I've added a workaround for the problem and was able to manually verify that the issue has been fixed.

@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Sep 1, 2020

FYI @Pilchie

@Pilchie
Copy link
Member

Pilchie commented Sep 1, 2020

@pranavkm - can you take another look with the changes?

Approved for RC1 pending CI completion, and @pranavkm's signoff if merged before 10am Pacific on 2020-09-01.

@Pilchie Pilchie requested a review from pranavkm September 1, 2020 00:11
@Pilchie Pilchie added the Servicing-approved Shiproom has approved the issue label Sep 1, 2020
@pranavkm
Update src/Middleware/Diagnostics.EntityFrameworkCore/src/DatabaseDev…
94a570d 
…eloperPageExceptionFilter.cs

Co-authored-by: Pranav K <[email protected]>
@JunTaoLuo JunTaoLuo merged commit 222dd67 into release/5.0 Sep 1, 2020
@JunTaoLuo JunTaoLuo deleted the johluo/templates-dberrorpage branch September 1, 2020 14:26
@JunTaoLuo JunTaoLuo mentioned this pull request Sep 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiercn javiercn javiercn approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher Tratcher is a code owner

+1 more reviewer

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Servicing-approved Shiproom has approved the issue tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JunTaoLuo @Pilchie @pranavkm @javiercn