Skip to content

Conversation

@benaadams
Copy link
Member

#25485 targeting 5.0-rc2

Currently can't use Certificates from config files if you link ASP.NET as all the setters for the config section are removed.

This directly references the properties rather than nebulously reflecting them via object so the linker will preserve them as they are directly used.

Resolves #25482

/cc @Tratcher

@ghost ghost added the area-servers label Sep 1, 2020
@Pilchie Pilchie added the community-contribution Indicates that the PR has been added by a community member label Sep 1, 2020
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😁

@Pilchie Pilchie added the Servicing-approved Shiproom has approved the issue label Sep 1, 2020
@Tratcher Tratcher added this to the 5.0.0-rc2 milestone Sep 1, 2020
@Pilchie
Copy link
Member

Pilchie commented Sep 1, 2020

Approved for RC2 pending CI Completion.

@benaadams
Copy link
Member Author

Error is some kind of maven.apache.org connection issue

* What went wrong:
Execution failed for task ':junitPlatformTest'.
> Could not resolve all files for configuration ':testRuntimeClasspath'.
   > Could not resolve org.junit.jupiter:junit-jupiter-engine:5.3.1.
     Required by:
         project :
      > Could not resolve org.junit.jupiter:junit-jupiter-engine:5.3.1.
         > Could not get resource 'https://repo.maven.apache.org/maven2/org/junit/jupiter/junit-jupiter-engine/5.3.1/junit-jupiter-engine-5.3.1.pom'.
            > Could not GET 'https://repo.maven.apache.org/maven2/org/junit/jupiter/junit-jupiter-engine/5.3.1/junit-jupiter-engine-5.3.1.pom'.
               > Connect to repo.maven.apache.org:443 [repo.maven.apache.org/151.101.188.215] failed: Connection timed out: connect

@Pilchie
Copy link
Member

Pilchie commented Sep 2, 2020

I started a re-run on those two jobs.

@Tratcher
Copy link
Member

Tratcher commented Sep 2, 2020

@Pilchie now it's ready to merge.

@Pilchie Pilchie merged commit ab3799f into dotnet:release/5.0-rc2 Sep 2, 2020
@benaadams benaadams deleted the Make-CertificateConfig-linker-friendly2 branch September 2, 2020 16:24
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants